Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
--+-
 Reporter:  mcs   |  Owner:  mcs
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by cypherpunks):

 * keywords:   => ff52-esr
 * component:  Applications/Torbutton => Applications/Tor Browser


Comment:

 Actual for e10s.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
--+-
 Reporter:  mcs   |  Owner:  mcs
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by mcs):

 Replying to [comment:4 cypherpunks]:
 > Actual for e10s.

 Do you mean that with e10s enabled, we *must* avoid requiring chrome
 privileges? I do not think that is true, so maybe you mean something else?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
+-
 Reporter:  mcs |  Owner:  mcs
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+-
Changes (by mcs):

 * keywords:  ff52-esr => ff52-esr, TorBrowserTeam201706


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  ff52-esr, TorBrowserTeam201706 => ff52-esr,
 TorBrowserTeam201706R
 * status:  new => needs_review


Comment:

 Here is a patch for review:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug18913-01&id=984af558af58bb8715af72c4811acc7fc4253bc1
 This change fixes #21948 and #22525 as well, so it would be great to
 include it in a Tor Browser release soon. While the patch is somewhat
 large, that is mainly because we had to move a lot of code out of
 torbutton.js into the new aboutTor-content.js content script (so it can
 run in the content process where the about:tor DOM is accessible).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 I forgot to mention that Kathy and I did some testing of this patch on
 OSX, Linux64, and Windows 10.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
+--
 Reporter:  mcs |  Owner:  mcs
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  ff52-esr, TorBrowserTeam201706R => ff52-esr,
 TorBrowserTeam201706
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:7 mcs]:
 > Here is a patch for review:
 >
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug18913-01&id=984af558af58bb8715af72c4811acc7fc4253bc1
 > This change fixes #21948 and #22525 as well, so it would be great to
 include it in a Tor Browser release soon. While the patch is somewhat
 large, that is mainly because we had to move a lot of code out of
 torbutton.js into the new aboutTor-content.js content script (so it can
 run in the content process where the about:tor DOM is accessible).

 Looks good to me, thanks! Just some nits:
 {{{
 +  // process that is only available here (in the chrome process). It is
 sent
 +  // sent to the content process when an about:tor window is opened and
 in
 }}}
 just one "sent"
 {{{
 +   kAboutTorMessages: [ "AboutTor:ChromeData", "AboutTor:ToolbarData" ],
 +
 +   get isAboutTor() {
 +return content.document.documentURI.toLowerCase() == "about:tor";
 }}}
 Indentation

 "the Tor Button item's x coordinate" -> "the x coordinate of Torbutton's
 toolbar item"

 "torbutton toolbar item" -> "Torbutton toolbar item"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * status:  needs_revision => needs_review
 * keywords:  ff52-esr, TorBrowserTeam201706 => ff52-esr,
 TorBrowserTeam201706R


Comment:

 Replying to [comment:9 gk]:
 > Looks good to me, thanks! Just some nits:
 > ...

 Thanks for your review! Here is a revised patch that fixes the things you
 found:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug18913-02

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
+--
 Reporter:  mcs |  Owner:  mcs
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  ff52-esr, TorBrowserTeam201706R => ff52-esr,
 TorBrowserTeam201706
 * status:  needs_review => needs_revision


Comment:

 Sorry, I should have given more context. You have now
 {{{
 +var AboutTorListener = {
 +   kAboutTorMessages: [ "AboutTor:ChromeData", "AboutTor:ToolbarData" ],
 +
 +   get isAboutTor() {
 + return content.document.documentURI.toLowerCase() == "about:tor";
 +  },
 }}}
 but I'd like to have it like
 {{{
 +var AboutTorListener = {
 +  kAboutTorMessages: [ "AboutTor:ChromeData", "AboutTor:ToolbarData" ],
 +
 +  get isAboutTor() {
 +return content.document.documentURI.toLowerCase() == "about:tor";
 +  },
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  ff52-esr, TorBrowserTeam201706 => ff52-esr,
 TorBrowserTeam201706R
 * status:  needs_revision => needs_review


Comment:

 I am sorry we botched the indentation fix, and I am sorry that we then
 forgot to revise the patch for the past two days. Do you have a git tool
 to spot those kind of errors, or just "eagle eyes?

 In any case, here is a revised patch:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug18913-03

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18913 [Applications/Tor Browser]: about:tor should not have chrome privileges

[Tor Bug Tracker & Wiki]

#18913: about:tor should not have chrome privileges
-+
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, TorBrowserTeam201706R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Just "eagle eyes". :) Applied to `master` (commit
 32f9cf56c89ccd2e24924975dc5515e4198d28c3).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs