Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
---+
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  closed
 Priority:  Low|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.4.5-alpha
 Severity:  Minor  | Resolution:  implemented
 Keywords:  easy, logging  |  Actual Points:  .1
Parent ID: | Points:  .1
 Reviewer:  arma   |Sponsor:
---+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 Fixed up and merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
---+
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  needs_revision
 Priority:  Low|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.4.5-alpha
 Severity:  Minor  | Resolution:
 Keywords:  easy, logging  |  Actual Points:  .1
Parent ID: | Points:  .1
 Reviewer:  arma   |Sponsor:
---+
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.5-alpha
 Severity:  Minor| Resolution:
 Keywords:  easy, logging, 029-nickm-says-yes,   |  Actual Points:  .1
  CoreTorTeam201606, review-group-3  |
Parent ID:   | Points:  .1
 Reviewer:  arma |Sponsor:
-+-

Comment (by teor):

 I could revise this, or someone else could pick it up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_revision
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |Version:  Tor:
  review-group-2, CoreTorTeam201606  |  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  .1
 | Points:  .1
 |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_information => needs_revision
 * points:  small => .1
 * actualpoints:  1 hour => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_information
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |Version:  Tor:
  review-group-2, CoreTorTeam201606  |  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-

Comment (by arma):

 Sounds great!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_information
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |Version:  Tor:
  review-group-2, CoreTorTeam201606  |  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_information
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |Version:  Tor:
  review-group-2, CoreTorTeam201606  |  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-

Comment (by nickm):

 Trivial suggested disambiguation: Add a # before the number.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |Version:  Tor:
  review-group-2, CoreTorTeam201606  |  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-

Comment (by arma):

 Ok, I found a moment to look at the patch. It has the problem that I
 expected it to have: there's no way to tell now whether somebody giving us
 one of these lines is using the old code or the new code -- so now seeing
 a log line talking about "hop 1" is ambiguous about whether it's the first
 relay or the second relay.

 In the distant future, this issue won't matter anymore, because nobody
 will be using the old code. But the distant future is years away.

 I think an easy fix might be to change something else in each of these log
 lines too, so it's possible, given just the log line, to disambiguate?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |Version:  Tor:
  review-group-2, CoreTorTeam201606  |  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-
Changes (by arma):

 * keywords:  easy, logging, 029-nickm-says-yes, review-group-2 => easy,
 logging, 029-nickm-says-yes, review-group-2, CoreTorTeam201606


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.???
 Keywords:  easy, logging, 029-proposed, 029 |Version:  Tor:
  -nickm-says-yes, review-group-2|  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Low  |  assigned
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.???
 Keywords:  easy, logging, 029-proposed, 029 |Version:  Tor:
  -nickm-says-yes, review-group-2|  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => assigned
 * owner:   => teor


Comment:

 setting owner

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-+-
 Reporter:  teor |  Owner:
 Type:  defect   | Status:
 Priority:  Low  |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Minor|  0.2.???
 Keywords:  easy, logging, 029-proposed, 029 |Version:  Tor:
  -nickm-says-yes|  0.2.4.5-alpha
Parent ID:   | Resolution:
 Reviewer:  arma |  Actual Points:  1 hour
 | Points:  small
 |Sponsor:
-+-
Changes (by arma):

 * reviewer:   => arma


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
---+---
 Reporter:  teor   |  Owner:
 Type:  defect | Status:  needs_review
 Priority:  Low|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor   |Version:  Tor:
 Severity:  Minor  |  0.2.4.5-alpha
 Keywords:  easy logging 029-proposed  | Resolution:
Parent ID: |  Actual Points:  1 hour
 Reviewer: | Points:  small
   |Sponsor:
---+---
Changes (by teor):

 * status:  new => needs_review
 * keywords:  easy logging => easy logging 029-proposed
 * version:   => Tor: 0.2.4.5-alpha
 * actualpoints:   => 1 hour


Comment:

 See my branch bug18982 on https://github.com/teor2345/tor.git

 It's a 2-line, 4-character fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
--+--
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  easy logging  |  Actual Points:
Parent ID:| Points:  small
 Reviewer:|Sponsor:
--+--
Description changed by teor:

Old description:

> The control-spec says hops are 1-based, and we often log "first hop":
> {{{
>   If HOP=HopNum is specified, Tor will choose the HopNumth hop in the
>   circuit as the exit node, rather than the last node in the circuit.
>   Hops are 1-indexed; generally, it is not permitted to attach to hop 1.
> }}}
>
> But the following functions log 0-based hops:
> * choose_good_middle_server
> * onion_extend_cpath (which also logs a 1-based hop message as well)
>
> We need to add 1 to the 0-based hop counts in these functions.

New description:

 The control-spec says hops are 1-based, and we often log "first hop":
 {{{
   If HOP=HopNum is specified, Tor will choose the HopNumth hop in the
   circuit as the exit node, rather than the last node in the circuit.
   Hops are 1-indexed; generally, it is not permitted to attach to hop 1.
 }}}

 But the following functions log 0-based hops:
 * choose_good_middle_server
 * onion_extend_cpath (which also logs a 1-based hop message as well)

 We need to add 1 to the 0-based hop counts in these functions.

 Credit to Xiaofan Li for discovering this issue.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
--+--
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:  easy logging
Actual Points:|  Parent ID:
   Points:  small |   Reviewer:
  Sponsor:|
--+--
 The control-spec says hops are 1-based, and we often log "first hop":
 {{{
   If HOP=HopNum is specified, Tor will choose the HopNumth hop in the
   circuit as the exit node, rather than the last node in the circuit.
   Hops are 1-indexed; generally, it is not permitted to attach to hop 1.
 }}}

 But the following functions log 0-based hops:
 * choose_good_middle_server
 * onion_extend_cpath (which also logs a 1-based hop message as well)

 We need to add 1 to the 0-based hop counts in these functions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs