Re: [tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201606R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed on tor-browser-45.2.0esr-6.5-1 with commit
 49d0c6389eea055e94a8fb492bd95de56b9111a4 and
 b60b8871fa08feaaca24bcf6dff43df0cd1c5f29, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201606R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arthuredelstein):

 Replying to [comment:7 mcs]:
 > Replying to [comment:6 mcs]:
 > > I tried to run the regression tests myself, but mach mochitest is not
 cooperating at the moment (I think this is due to Mac OS 10.11 Python
 differences; it is definitely not related to the tests themselves).
 >
 > OK, I was able to run tbb-tests/test_tor_bug1517.html on a different
 system and it worked correctly. I guess the test does not care about the
 silence.ogg vs. audio.ogg difference (but it should probably be fixed).

 Thanks for catching that mistake. I've corrected it here:

 https://github.com/arthuredelstein/tor-browser/commits/19193+1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201606R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 Replying to [comment:6 mcs]:
 > I tried to run the regression tests myself, but mach mochitest is not
 cooperating at the moment (I think this is due to Mac OS 10.11 Python
 differences; it is definitely not related to the tests themselves).

 OK, I was able to run tbb-tests/test_tor_bug1517.html on a different
 system and it worked correctly. I guess the test does not care about the
 silence.ogg vs. audio.ogg difference (but it should probably be fixed).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201606R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 For the regression test patch (936cadcc8dd2b0e6784be69cabe44880e36839b0),
 the test code references silence.ogg but the patch adds a file named
 audio.ogg. Shouldn't they match?

 The currentTime rounding patch (b91f47cce42a2e048f970a18710f9c15672a6cfc)
 looks good.

 I tried to run the regression tests myself, but mach mochitest is not
 cooperating at the moment (I think this is due to Mac OS 10.11 Python
 differences; it is definitely not related to the tests themselves).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201605R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: mcs, brade (added)


Comment:

 Looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201605R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arthuredelstein):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201605 => TorBrowserTeam201605R


Old description:

> The worst offender is probably AudioContext, where you can get
> the current time thus:
>
> {{{
> var audioContext = new AudioContext();
> audioContext.currentTime;
> }}}
>
> Similarly, HTMLVideoElement.currentTime, HTMLAudioElement.currentTime,
> and CanvasCaptureMediaStream.currentTime can be used as a time source
> with resolution better than 10 ms.

New description:

 The worst offender is probably AudioContext, where you can get
 the current time thus:

 {{{
 var audioContext = new AudioContext();
 audioContext.currentTime;
 }}}

 Similarly, HTMLVideoElement.currentTime, HTMLAudioElement.currentTime, and
 CanvasCaptureMediaStream.currentTime can each be used as a time source
 with resolution better than 10 ms.

--

Comment:

 Here is a branch with two patches.

 https://github.com/arthuredelstein/tor-browser/commits/19193

 b91f47cce42a2e048f970a18710f9c15672a6cfc is a fixup for our #1517 patch
 that rounds the values returned by the `currentTime` attributes mentioned
 above.

 936cadcc8dd2b0e6784be69cabe44880e36839b0 provides regression tests for all
 time sources we are rounding in the old and new patches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19193 [Applications/Tor Browser]: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to content scripts

[Tor Bug Tracker & Wiki]

#19193: AudioContext, HTMLMediaElement, and MediaStream provide currentTime to
content scripts
--+
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  TorBrowserTeam201605
   Points:|  Parent ID:
  Sponsor:|   Reviewer:
--+
 The worst offender is probably AudioContext, where you can get
 the current time thus:

 {{{
 var audioContext = new AudioContext();
 audioContext.currentTime;
 }}}

 Similarly, HTMLVideoElement.currentTime, HTMLAudioElement.currentTime, and
 CanvasCaptureMediaStream.currentTime can be used as a time source with
 resolution better than 10 ms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs