Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+--
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam201608R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed on tor-browser-45.3.0esr-6.0-1 (commit
 7c50120b217807b98a8a99d16c53b760d2119280) and tor-browser-45.3.0esr-6.5-1
 (commit b8726ee81e6eca2e302e2ea85c0d09ad22be1ec5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+---
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201608R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by arthuredelstein):

 Also looks good to me. Sorry for the delay!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+---
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201608R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * cc: arthuredelstein (added)


Comment:

 Looks good to me. Arhur, could you have a look at it as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+---
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:
 Priority:  Medium |  needs_review
Component:  Applications/Tor Browser   |  Milestone:
 Severity:  Normal |Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607R  | Resolution:
Parent ID: |  Actual Points:
 Reviewer: | Points:
   |Sponsor:
---+---

Comment (by amoghbl1):

 Replying to [comment:9 mcs]:
 > Please try the following patch:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19706-01&id=d86fa0e328b8ea6a07741b55da5cc1bebb669b88

 This patch works fine with our build. Thank you for it!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+---
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:
 Priority:  Medium |  needs_review
Component:  Applications/Tor Browser   |  Milestone:
 Severity:  Normal |Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607R  | Resolution:
Parent ID: |  Actual Points:
 Reviewer: | Points:
   |Sponsor:
---+---
Changes (by mcs):

 * status:  assigned => needs_review
 * keywords:  tbb-mobile, TorBrowserTeam201607 => tbb-mobile,
 TorBrowserTeam201607R


Comment:

 Please try the following patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19706-01&id=d86fa0e328b8ea6a07741b55da5cc1bebb669b88

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+--
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201607  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by amoghbl1):

 Replying to [comment:6 mcs]:
 > Replying to [comment:4 amoghbl1]:
 > > I don't think that we require a patch right now, as I'm fine with
 using this one for builds we're trying to get out now. But it would be
 useful to have this fixed by the next time we do a rebase.
 >
 > I am concerned that we will forget about this if we do not address it
 now. If Kathy and I create a patch, do you have time to try it (compile it
 and let us know if it works)?

 Sure, I will test it out once it's ready and verify whether it works or
 not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+--
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201607  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_information => assigned


Comment:

 Yes, we should write a patch for that now-ish. We already forgot this
 once.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:
 Priority:  Medium|  needs_information
Component:  Applications/Tor Browser  |  Milestone:
 Severity:  Normal|Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607  | Resolution:
Parent ID:|  Actual Points:
 Reviewer:| Points:
  |Sponsor:
--+
Changes (by mcs):

 * status:  needs_revision => needs_information


Comment:

 Replying to [comment:4 amoghbl1]:
 > I don't think that we require a patch right now, as I'm fine with using
 this one for builds we're trying to get out now. But it would be useful to
 have this fixed by the next time we do a rebase.

 I am concerned that we will forget about this if we do not address it now.
 If Kathy and I create a patch, do you have time to try it (compile it and
 let us know if it works)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:
 Priority:  Medium|  needs_revision
Component:  Applications/Tor Browser  |  Milestone:
 Severity:  Normal|Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607  | Resolution:
Parent ID:|  Actual Points:
 Reviewer:| Points:
  |Sponsor:
--+

Comment (by n8fr8):

 In the case of Android, each app is a user itself, and so the home is a
 path unique for the app, and that only the app can read and write to.
 There is no other way or place for the data to be safely stored.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:
 Priority:  Medium|  needs_revision
Component:  Applications/Tor Browser  |  Milestone:
 Severity:  Normal|Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607  | Resolution:
Parent ID:|  Actual Points:
 Reviewer:| Points:
  |Sponsor:
--+

Comment (by amoghbl1):

 We don't mind building with or without the --enable-tor-browser-data-
 outside-app-dir flag.

 I think I will let you get this patched as I'm not sure what the best way
 to deal with it is.

 I don't think that we require a patch right now, as I'm fine with using
 this one for builds we're trying to get out now. But it would be useful to
 have this fixed by the next time we do a rebase.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:
 Priority:  Medium|  needs_revision
Component:  Applications/Tor Browser  |  Milestone:
 Severity:  Normal|Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607  | Resolution:
Parent ID:|  Actual Points:
 Reviewer:| Points:
  |Sponsor:
--+
Changes (by mcs):

 * keywords:  tbb-mobile, TorBrowserTeam201607R => tbb-mobile,
 TorBrowserTeam201607
 * status:  needs_review => needs_revision


Comment:

 Thanks for tracking this down and for providing a patch.

 It looks like Orfox stores the browser profile data in the user's home
 directory (or wherever $HOME points to). If that is the case, then in the
 long run Orfox should be built with --enable-tor-browser-data-outside-app-
 dir (which causes TOR_BROWSER_DATA_OUTSIDE_APP_DIR to be defined; see
 #13252). Unfortunately, the code we added for #13252 has only been tested
 on OSX so you may not want to use --enable-tor-browser-data-outside-app-
 dir yet.

 Regardless of whether Orfox uses --enable-tor-browser-data-outside-app-dir
 or not, Kathy and I would like to use a revised patch that modifies
 TorBrowser_GetUserDataDir() (which is inside xpcom/io/TorFileUtils.cpp).
 We may also need to make a small patch to
 nsXREDirProvider::GetUserDataDirectoryHome() to avoid putting the data
 underneath a Data/Browser subdirectory within $HOME.

 Do you want Kathy and me to provide an untested patch for you to try, or
 do you want to create a revised patch?

 For example, if you do not build with --enable-tor-browser-data-outside-
 app-dir, you would want to insert a {{{#elif defined(ANDROID)}}} block
 before the following code in TorBrowser_GetUserDataDir():
 {{{
 #else
   // User data is embedded within the application directory (i.e.,
   // TOR_BROWSER_DATA_OUTSIDE_APP_DIR is not defined).
   nsresult rv = GetAppRootDir(aExeFile, getter_AddRefs(tbDataDir));
   NS_ENSURE_SUCCESS(rv, rv);
   rv = tbDataDir->AppendNative(NS_LITERAL_CSTRING("TorBrowser"));
   NS_ENSURE_SUCCESS(rv, rv);
 #endif
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+---
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:
 Priority:  Medium |  needs_review
Component:  Applications/Tor Browser   |  Milestone:
 Severity:  Normal |Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607R  | Resolution:
Parent ID: |  Actual Points:
 Reviewer: | Points:
   |Sponsor:
---+---

Comment (by gk):

 Amogh says this is #9173 related.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
---+---
 Reporter:  amoghbl1   |  Owner:  tbb-team
 Type:  defect | Status:
 Priority:  Medium |  needs_review
Component:  Applications/Tor Browser   |  Milestone:
 Severity:  Normal |Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607R  | Resolution:
Parent ID: |  Actual Points:
 Reviewer: | Points:
   |Sponsor:
---+---
Changes (by gk):

 * keywords:  tbb-mobile => tbb-mobile, TorBrowserTeam201607R
 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19706 [Applications/Tor Browser]: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox

[Tor Bug Tracker & Wiki]

#19706: GetUserDataDirectoryHome in nsXREDirProvider.cpp breaks Orfox
--+
 Reporter:  amoghbl1  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 The GetUserDataDirectoryHome seems to break the page loading in Orfox.
 I'm going to attach the patch that I have for this to this ticket, but I
 think it could be cleaner, I'm not sure what you would require though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs