Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-10-07 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  tbb-sandboxing, tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by bugzilla):

 * keywords:  tbb-sandbox, tbb-torbutton, TorBrowserTeam201609R => tbb-
 sandboxing, tbb-torbutton, TorBrowserTeam201609R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-09-08 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks, applied with commit 5ea022aadf6416a1f046eac47a3ec28ea2a5dd7d.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-09-08 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  tbb-sandbox, tbb-torbutton, TorBrowserTeam201609 => tbb-
 sandbox, tbb-torbutton, TorBrowserTeam201609R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:11 gk]:
 > Looks good with one nit: I guess removing the very first line in
 `torbutton.js` is just an oversight? I think we should keep that one. :)

 Yes indeed. Here is a revised patch:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-04=5ea022aadf6416a1f046eac47a3ec28ea2a5dd7d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-09-08 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-sandbox, tbb-torbutton, TorBrowserTeam201609R => tbb-
 sandbox, tbb-torbutton, TorBrowserTeam201609
 * status:  needs_review => needs_revision


Comment:

 Looks good with one nit: I guess removing the very first line in
 `torbutton.js` is just an oversight? I think we should keep that one. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-09-07 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:9 arthuredelstein]:
 > Replying to [comment:7 mcs]:
 > > Here is a new patch:
 > >
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-02=f1932e73ee5199969f49ce595fb30ec14e76cb52
 > Minor things:
 > {{{
 > + if (socksAddr && (socksAddr.substr(0, 5) == "file:")) {
 > }}}
 > Can this be `sockAddr.startsWith("file:")`?

 Done.

 > {{{
 > + foundSocksListener = (socketPath == path);
 > }}}
 > {{{
 > +  foundSocksListener = ((socksAddr == torSocksAddr) &&
 > +(socksPort == torSocksPort));
 > }}}
 > I would suggest using `===` (triple equals) for safety.

 OK. We fixed another place too where == was used instead of ===. While
 testing, we discovered that file: URLs that begin with file:/// were not
 handled correctly (and they should begin that way). So we rewrote the code
 that converts the network.proxy.socks value to a file path. Please review:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-03=a07ceb4e7974a1369a1d6484cbfce0a7ec9e503f

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-09-02 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:7 mcs]:
 > Here is a new patch:
 >
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-02=f1932e73ee5199969f49ce595fb30ec14e76cb52
 Minor things:
 {{{
 + if (socksAddr && (socksAddr.substr(0, 5) == "file:")) {
 }}}
 Can this be `sockAddr.startsWith("file:")`?
 {{{
 + foundSocksListener = (socketPath == path);
 }}}
 {{{
 +  foundSocksListener = ((socksAddr == torSocksAddr) &&
 +(socksPort == torSocksPort));
 }}}
 I would suggest using `===` (triple equals) for safety.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-08-26 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * status:  needs_revision => needs_review


Comment:

 Here is a new patch:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-02=f1932e73ee5199969f49ce595fb30ec14e76cb52

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-08-26 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * status:  needs_review => needs_revision


Comment:

 Mozilla changed their implementation to use file: URLs instead of simple
 paths (see https://bugzilla.mozilla.org/show_bug.cgi?id=1211567#c22). We
 will revise this patch accordingly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-08-15 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
-+-
 Reporter:  yawning  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton,  |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  tbb-sandbox, tbb-torbutton => tbb-sandbox, tbb-torbutton,
 TorBrowserTeam201608R
 * status:  new => needs_review


Comment:

 Kathy and I decided to begin our UNIX domain socket journey by fixing this
 bug. Here is a patch:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19733-01=db21620ac199bd4bc25939f14c6c44093b89

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-07-22 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
+--
 Reporter:  yawning |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Very Low|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Minor   | Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton  |  Actual Points:
Parent ID:  #14270  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by mcs):

 * cc: brade, mcs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19733 [Applications/Tor Browser]: GETINFO response parser doesn't handle AF_UNIX entries.

2016-07-21 Thread Tor Bug Tracker & Wiki 
#19733: GETINFO response parser doesn't handle AF_UNIX entries.
+--
 Reporter:  yawning |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Very Low|  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Minor   | Resolution:
 Keywords:  tbb-sandbox, tbb-torbutton  |  Actual Points:
Parent ID:  #14270  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * owner:   => tbb-team
 * keywords:  tbb-sandbox => tbb-sandbox, tbb-torbutton
 * component:  Applications/Torbutton => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs