Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.1.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  implemented
  code easy  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Merged to master; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.1.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * status:  accepted => needs_review


Comment:

 Please see my patch in my `bug19871`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug19871 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.1.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * version:   => Tor: 0.1.2.4-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * status:  new => accepted
 * owner:   => isis
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 The only place these statistics are used is at the end of `dumpstats(int
 severity)` where `dump_pk_ops()` is called after getting a SIGUSR1 signal
 (but only if `severity < LOG_INFO`). You're both right that these
 statistics seem a bit useless, because this info is kind of weird info to
 keep around, i.e. I'm not sure why we'd want to know how many times we did
 TLS or how many signatures we verified.  (More seemingly useful info about
 public key operations would be higher-level, e.g. routers we're talking to
 for which some crypto operation has an anomalous failure rate.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * sponsor:   => Sponsor3-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
-+-
Changes (by isis):

 * cc: isis (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  029-proposed => 029-proposed technnical-debt dead-code easy


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
--+--
 Reporter:  asn   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  029-proposed
Actual Points:|  Parent ID:
   Points:  0.3   |   Reviewer:
  Sponsor:|
--+--
 Nick told me that the crypto operation counters in `rephist.c` are
 considered unused and obsolete.

 I'm talking about the counters at `note_crypto_pk_op()` etc.

 Removing code is always good, so if these things are unused we might as
 well remove them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs