Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This is fixed on tor-browser-45.3.0esr-6.0-1 and tor-
 browser-45.3.0esr-6.5-1 (commit 61700466ddefff3005633a6e31f34133eb98197f
 and 8af42ff851bab2d9b17d380c170f06c28b94c74b) and will be in our next
 stable, 6.0.4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 #19900 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by in spatium):

 Replying to [ticket:19890 arthuredelstein]:
 > On Tor Browser 6.0.3 (up-to-date) I saw the following warning appear
 below the URL bar:
 >
 > "Your Firefox is out of date. Please download a fresh copy." On the
 right is a button that says "Get Firefox". Obviously we want to disable
 this warning.

 Solution --
 Go to about:config/extensions.bootstrappedAddon
 Reset the string Value to empty Value {}
 Restart Tor browser.
 The warning will not appear again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Just as an update: this issue got fixed on Mozilla's side meanwhile
 (thanks to bhearsum and all the other Mozilla folks that helped).

 We might want to think about shipping an update though (containing the fix
 on our side and an updated tor maybe).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I guess we could I guess, I followed mcs and brade in patching firefox.js
 here. I think for the fixup release doing that is fine.

 FWIW: The alpha and hardened series is not affected and Tails neither
 (they have `app.update.enabled` set to `false`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:9 gk]:
 > Good idea, thanks. I've been a bit too fast it seems. The fix
 (https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-45.3.0esr-6.0-1=61700466ddefff3005633a6e31f34133eb98197f) was
 aimed to go into my public repo not directly to tor-browser-45.3.0-6.0-1.
 Please review, I am holding off starting a build for 6.0.4 until somebody
 looked at it.

 Rather than patching firefox.js directly, maybe we should apply this
 setting in  `browser/app/profile/000-tor-browser.js` as we have with most
 other prefs? (I notice we have two other changes to firefox.js (from our
 patches for #5472 and #4234) -- maybe these should also be migrated to 000
 -tor-browser.js?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608R,   |  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201608, tbb-6.0-issues => TorBrowserTeam201608R,
 tbb-6.0-issues
 * status:  new => needs_review


Comment:

 Good idea, thanks. I've been a bit too fast it seems. The fix
 (https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-45.3.0esr-6.0-1=61700466ddefff3005633a6e31f34133eb98197f) was
 aimed to go into my public repo not directly to tor-browser-45.3.0-6.0-1.
 Please review, I am holding off starting a build for 6.0.4 until somebody
 looked at it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608,|  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:7 cypherpunks]:
 > `extensions.systemAddon.update.url` should be set to "".

 I think this is a good solution. To check this, I found the location of
 the XPI in Tor Browser:
 {{{
 arthur@localhost ~/t/Browser> find . -name "*outofdate*"
 ./TorBrowser/Data/Browser/profile.default/features/{541bf4ef-2e8d-
 44d5-9aa1-887165d68eec}/outofdate-notificati...@mozilla.org.xpi
 
./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864327100
 .72bc501f-cad6-4be7-b082-9af725197de9.outofdate-notifications-system-
 addon.jsonlz4
 
./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864333700.c7c02599-f462-49f2-8f11-fad83bfc976c
 .outofdate-notifications-system-addon.jsonlz4
 }}}
 After setting the pref to "", I opened Tor Browser and entered the
 following in the browser console:
 {{{
 Cu.import("resource://gre/modules/AddonManager.jsm");
 AddonManagerPrivate.backgroundUpdateCheck();
 }}}
 Then I confirmed that the XPI had been removed:
 {{{
 arthur@localhost ~/t/Browser> find . -name "*outofdate*"
 
./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864327100
 .72bc501f-cad6-4be7-b082-9af725197de9.outofdate-notifications-system-
 addon.jsonlz4
 
./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864333700.c7c02599-f462-49f2-8f11-fad83bfc976c
 .outofdate-notifications-system-addon.jsonlz4
 }}}
 Here is the relevant code that apparently removes the XPI file. When the
 pref is empty, `url` is falsey and `yield
 systemAddonLocation.cleanDirectories();` is called:
 https://dxr.mozilla.org/mozilla-central/rev
 
/0502bd9e025edde29777ba1de4280f9b52af4663/toolkit/mozapps/extensions/internal/XPIProvider.jsm#3069

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608,|  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 `extensions.systemAddon.update.url` should be set to "".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608,|  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1294395 and
 poked the Mozilla folks on #releng. Hopefully they can tweak the server-
 side rules in order to affect less of our users while we are working on
 getting a new version out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201608,|  Actual Points:
  tbb-6.0-issues |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201608 => TorBrowserTeam201608, tbb-6.0-issues


Comment:

 Replying to [comment:1 arthuredelstein]:
 > Looks like it came from this bug.
 > https://bugzilla.mozilla.org/show_bug.cgi?id=1280378
 >
 > I'm not sure yet how it gets into Firefox (or Tor Browser for that
 matter).

 It seems the infrastructure was already there starting with Firefox 44:

 https://bugzilla.mozilla.org/show_bug.cgi?id=1192924 and
 https://bugzilla.mozilla.org/show_bug.cgi?id=1213348.

 Now, they probably just were ready with the "your Firefox is out of
 date"-system add-on. I guess we should just disable that update ping with
 our `data:text/plain,` trick. And think about how to get rid of already
 installed system extensions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  TorBrowserTeam201608  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: b_meson (added)


Comment:

 #19891 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  TorBrowserTeam201608  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * priority:  Medium => Very High
 * severity:  Normal => Critical


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201608  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 Possibly relevant:
 http://gecko.readthedocs.io/en/latest/toolkit/mozapps/extensions/addon-
 manager/SystemAddons.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201608  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arthuredelstein):

 Looks like it came from this bug.
 https://bugzilla.mozilla.org/show_bug.cgi?id=1280378

 I'm not sure yet how it gets into Firefox (or Tor Browser for that
 matter).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
--+
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201608
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 On Tor Browser 6.0.3 (up-to-date) I saw the following warning appear below
 the URL bar:

 "Your Firefox is out of date. Please download a fresh copy." On the right
 is a button that says "Get Firefox". Obviously we want to disable this
 warning.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs