Re: [tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Rebased to master, tweaked some trivial whitespace issues, tested locally,
 and pushed to master.  Closing, together with #19894.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_revision => needs_review


Comment:

 Good catch! Unfortunately this cannot be simulated using junit.

 Please review
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19894
 -and-task-19895&id=236e7d4c4cb78de9b91dda5d74dabcf6df1d3d56 one commit]
 adapting the tests to the change in #19894 and the
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19894
 -and-task-19895&id=9790827d50e0b62a5c9d272c39d73b7c829f1cb8 second commit]
 correcting the run-once functionality.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Hmm, it seems that I'm running out of non-daemon threads now.  Execution
 stops immediately after writing this log file:

 {{{
 $ cat collector-all.log
 2016-08-24 12:34:05,688 INFO o.t.c.cron.Scheduler:80 Single run for
 org.torproject.collector.relaydescs.ArchiveWriter.
 2016-08-24 12:34:05,724 INFO o.t.c.cron.Scheduler:130 New Thread created:
 CollecTor-Scheduled-Thread-1
 }}}

 Here's my config file, as compared to defaults:

 {{{
 $ diff src/main/resources/collector.properties collector.properties
 10c10
 < RunOnce = false
 ---
 > RunOnce = true
 24c24
 < RelaydescsActivated = false
 ---
 > RelaydescsActivated = true
 83c83
 < DownloadRelayDescriptors = false
 ---
 > DownloadRelayDescriptors = true
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  new => needs_review


Comment:

 I was wondering why this didn't get attention, well, setting it to
 needs_review might help.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by iwakeh):

 Please review
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19894
 -and-task-19895&id=0c63b2769977de18a6ba0113b2a52c26948ab1d8 this commit]
 (optimistically based on the implementation of the related task-19894).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * milestone:   => CollecTor 1.1.0


Comment:

 For release 1.1.0 as it is clearly visible in the log when it is save to
 terminate the jvm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19895 [Metrics/CollecTor]: make CollecTor stop after RunOnce

[Tor Bug Tracker & Wiki]

#19895: make CollecTor stop after RunOnce
---+
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+
 The activated modules are run one time, which is correct.
 The configuration check thread just keeps running and thus CollecTor w/o
 doing anything.

 Suggested behavior:
 Exit CollecTor after all activated modules ran one time.

 (related to #19894)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs