Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-usability, TorBrowserTeam201611R => tbb-usability,
 TorBrowserTeam201611R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Yes, normally all the changes on tor-browser-45.5.0esr-6.5-1 would have
 made it into 6.5a5 but dealing with a 0-day exploit is quite non-normal.
 Thus, in order to minimize the risk for breakage I decided to include only
 the most important patches into the update which left out the things you
 mentioned. 6.5a6 getting released next week will contain them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by viktorj):

 I noticed that this is indeed fixed in the 45.5.0esr-6.5-1 branch, but the
 commit was not included in the 6.5a5(-hardened) upload. So feel free to
 close this ticket again or see this as a reminder to include the fix in
 the next upload.

 BTW, there were also three other commits in the 45.5.0esr-6.5-1 branch
 which were not included in the 6.5a5(-hardened) upload. I couldn't find
 any "master" branch or something similar, so I assumed that only the
 latest branch is relevant for bug fixing, especially since this is a
 ticket concerning the alpha version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by viktorj):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This is not fixed for me in Tor Browser 6.5a5 and 6.5a5-hardened, both
 with german language pack enabled. I get with both this:
 {{{
 XML-Verarbeitungsfehler: Nicht definierte Entität
 Adresse: about:preferences
 Zeile Nr. 647, Spalte 7:  https://trac.torproject.org/projects/tor/ticket/20707#comment:8>
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, let's take it for the alpha. Seems to be an okay stopgap solution.
 This is commit 70b2e4769bc4a7dd877e8ca82403d71561dbeec8 on tor-
 browser-45.5.0esr-6.5-1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:5 mcs]:
 > Replying to [comment:2 arthuredelstein]:
 > > ... Therefore I'm proposing this separate follow-up patch that removes
 the references for Tor Browser only.
 > >
 > > https://github.com/arthuredelstein/tor-browser/commit/20707
 >
 > r=mcs
 > I think this is an okay solution, although it looks strange to use hard-
 coded strings.
 > Maybe the commit message state that this is a fixup for 20244 instead of
 using this new ticket number?

 The reason I did it this way is that I wanted to keep the original patch
 separate for possible uplift. The hard-coded strings are merely
 placeholders that are hidden by the torbutton overlay.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:2 arthuredelstein]:
 > ... Therefore I'm proposing this separate follow-up patch that removes
 the references for Tor Browser only.
 >
 > https://github.com/arthuredelstein/tor-browser/commit/20707

 r=mcs
 I think this is an okay solution, although it looks strange to use hard-
 coded strings.
 Maybe the commit message state that this is a fixup for 20244 instead of
 using this new ticket number?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 This issue also prevents me from changing the default search engine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: cactusjack (added)


Comment:

 Resolved #20726 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-usability, TorBrowserTeam201611 => tbb-usability,
 TorBrowserTeam201611R
 * status:  new => needs_review


Comment:

 It seems that, even though torbutton is overlaying these checkbox labels
 with localized strings, XUL still wants to look up the original labels in
 tor-browser.git, which exist only in the en-US locale. So the solution
 seems to be to remove any references to localized strings in tor-
 browser.git. But we want to keep those references in our original #20244
 patches so that Mozilla can uplift and localize them. Therefore I'm
 proposing this separate follow-up patch that removes the references for
 Tor Browser only.

 https://github.com/arthuredelstein/tor-browser/commit/20707

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-usability, TorBrowserTeam201611  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Diapolo):

 * cc: buschfeuer@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

[Tor Bug Tracker & Wiki]

#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-usability,
 Severity:  Major|  TorBrowserTeam201611
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We have reports that in non-en-US builds the preferences tab is not
 opening anymore with an XML parsing error:
 {{{
 "XML-Verarbeitungsfehler: Nicht definierte Entität
 Adresse: about:preferences
 Zeile Nr. 653, Spalte 7: --^"

 Something like XML processing error: Undefined entity adress:
 about:preferences row 653 column 7.
 }}}
 https://blog.torproject.org/blog/tor-browser-65a4-released#comment-219453
 and
 https://blog.torproject.org/blog/tor-browser-65a4-hardened-
 released#comment-219407.

 This is very likely due to #20244.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs