Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201701R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  TorBrowserTeam201612R => TorBrowserTeam201701R
 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Okay, this works for me (as in: `make prep-nightly` does not break
 anymore) and is applied to `master` and `hardened-builds` (commit
 3cf7b5af18a4fa0ad0813c0e16148dc1e578c04a and
 96836418e9686ea775759bbe15c39cbc3855969d).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 Ok, attached is a patch that should get us unblocked.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 Ok, confirmed that I get the same thing as you.  And yes, this is the
 result of a recent upstream change.

 I believe the problem is that `fetch --nohooks --no-history webrtc` calls
 `gclient sync` without passing a revision (`-r`), and therefore checkouts
 the head, which we then up reverting in the next step.

 Working on a fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 Hmm, sorry about that.  I started one just now; will let you know.
 Something may have changed very recently, or maybe I messed up the rebase
 (though I did try a build with the commit at the time).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Our nightly builds is failing for some reason (ln5 reported "sha256sum:
 webrtc.tar.gz: No such file or directory" and "fatal: ambiguous argument
 'master': unknown revision or path not in the working tree."). I tried to
 look at it on my regular build machine and things are already broken while
 fetching the source code:
 {{{
 ACTION REQUIRED:
 Before running `gclient sync|runhooks` again, you must run:
 src/setup_links.py --force

 Which will replace all directories which now must be symlinks, after
 prompting with a summary of the work-to-be-done.


 Error: Command '/usr/bin/python src/setup_links.py' returned non-zero exit
 status 1 in /home/gk/dev/gitian-builder/inputs/webrtc
 Makefile:97: recipe for target 'prep-nightly' failed
 make: *** [prep-nightly] Error 2
 }}}
 I wonder if there is something that changed here recently as I remember
 building Snowflake on that machine but then got rid of all the related
 sources again.

 Could you double-check that a clean tor-browser-bundle checkout (commit
 761b0dbabd8fd14e8d9149634b52869f0c68375b) + a `make prep-nightly` is
 working for you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 > I was a bit confused as the last patch from arlolra indicated that it is
 Patch 1/3. (That's what is contained in the Subject line). Thus, if there
 is anything else that needs to get addressed on our side let me know.

 Sorry, patches 2 and 3 are the macOS and Windows bits, respectively, which
 we aren't doing here yet (see https://github.com/arlolra/tor-browser-
 bundle/commits/sf-set).  So, no, nothing else to address.

 Thanks for merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:20 serene]:
 > Hi -- checking in on this.
 >
 > @gk: Do you have everything you need for the integration, and are we on
 track for the January alpha release?

 Yes, and yes, thanks. I just did the annual christmas traveling and had
 some days off which is the only reason for this delay. I applied the patch
 to `master` and merged the previous one into `hardened-builds` (as
 `hardened-builds` does not ship the sandbox). The result is commit
 761b0dbabd8fd14e8d9149634b52869f0c68375b,
 f78866cad71122fa851ebdf6c63053605c565826 and
 2eca5d42245a98b4572943b0307a74392bfa4f5c.

 I was a bit confused as the last patch from arlolra indicated that it is
 Patch 1/3. (That's what is contained in the Subject line). Thus, if there
 is anything else that needs to get addressed on our side let me know.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by serene):

 Hi -- checking in on this.

 @gk: Do you have everything you need for the integration, and are we on
 track for the January alpha release?

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201612R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arlolra):

 * keywords:   => TorBrowserTeam201612R
 * status:  needs_revision => needs_review


Comment:

 > I am sorry about that but could you rebase your patch one last time?

 No problem.  See the attached.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * keywords:  TorBrowserTeam201612R =>
 * status:  needs_review => needs_revision


Comment:

 I am sorry about that but could you rebase your patch one last time? I
 needed to get the sandbox bundling and building landed for our SponsorU
 deadline and it changed a bunch of things that are affecting the snowflake
 integration.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 Great, thanks.  That's more than reasonable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:14 arlolra]:
 > > How about this: We get snowflake into the nightlies for now and plan
 to ship it into the alpha after the next one (which is due in January
 2017).
 >
 > Sounds good.  To be clear, is it the next one that goes out in January,
 or the one after?  (Words are hard.)

 Indeed. So, the next release will be on Dec 13/Dec 14. And snowflake could
 then get included in the alpha that goes out in January.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 > How about this: We get snowflake into the nightlies for now and plan to
 ship it into the alpha after the next one (which is due in January 2017).

 Sounds good.  To be clear, is it the next one that goes out in January, or
 the one after?  (Words are hard.)

 > And you are trying to take care of #20813 meanwhile?

 Yes, I've initiated a discussion with the team.

 > We need to freeze the code for the next alpha next week and it seems to
 me that timeframe might be too short to get #20813 done sufficiently. Or
 am I wrong in that regard?

 No, that's probably fair to say.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:12 arlolra]:
 > > I don't think so.
 >
 > Ok, I guess I was confused by your "propagate that to get the browser
 proxy more widely distributed".  The `snowflake-client` built here is
 independent of the proxy.  Anyways, we're on the same page.  Sorry.

 No worries, I should have framed it better. :)

 > > Yes, let's do that. What I want to avoid is alpha users having
 basically zero chances of getting a working Snowflake and coming instead
 to us claiming it is broken.
 >
 > Gotcha, see #20813

 Thanks. How about this: We get snowflake into the nightlies for now and
 plan to ship it into the alpha after the next one (which is due in January
 2017). And you are trying to take care of #20813 meanwhile? We need to
 freeze the code for the next alpha next week and it seems to me that
 timeframe might be too short to get #20813 done sufficiently. Or am I
 wrong in that regard?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 > I don't think so.

 Ok, I guess I was confused by your "propagate that to get the browser
 proxy more widely distributed".  The `snowflake-client` built here is
 independent of the proxy.  Anyways, we're on the same page.  Sorry.

 > Yes, let's do that. What I want to avoid is alpha users having basically
 zero chances of getting a working Snowflake and coming instead to us
 claiming it is broken.

 Gotcha, see #20813

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:10 arlolra]:
 > > Wouldn't it be smarter to have, say, Snowflake in our nightly builds
 first for a while, propagate that to get the browser proxy more widely
 distributed and then ship it in alphas?
 >
 > Maybe there's a misunderstanding here.

 I don't think so.

 > The proxies (snowflakes) are run by random internet users in uncensored
 regions.  They just need to navigate to a certain website and then their
 browser takes over.  Distributing it widely means hosting the badge on
 say, torproject.org, or some other highly trafficked site.

 Yes, let's do that. What I want to avoid is alpha users having basically
 zero chances of getting a working Snowflake and coming instead to us
 claiming it is broken.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 > Wouldn't it be smarter to have, say, Snowflake in our nightly builds
 first for a while, propagate that to get the browser proxy more widely
 distributed and then ship it in alphas?

 Maybe there's a misunderstanding here.

 The proxies (snowflakes) are run by random internet users in uncensored
 regions.  They just need to navigate to a certain website and then their
 browser takes over.  Distributing it widely means hosting the badge on
 say, torproject.org, or some other highly trafficked site.

 It's the same model as flashproxy (https://crypto.stanford.edu/flashproxy
 /#how-it-works).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:4 arlolra]:
 > > 3) Snowflake is not working:
 >
 > The browser proxy has not been distributed widely yet, so noone is
 coming along in time to answer your offer.  Try visiting
 https://keroserene.net/snowflake/snowflake.html in another browser
 simultaneously, or run one locally https://gitweb.torproject.org
 /pluggable-transports/snowflake.git/tree/proxy/README.md#n18

 So, how are users in our alphas then supposed to use Snowflake? Wouldn't
 it be smarter to have, say, Snowflake in our nightly builds first for a
 while, propagate that to get the browser proxy more widely distributed and
 then ship it in alphas? Right now all the users get is Snowflake not
 working which is sort of counterintuitive if we ship it in an alpha build
 (as showing it in the PT drop down box indicates that it is something
 which is actually usable).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => TorBrowserTeam201611R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by gk):

 Replying to [comment:5 arlolra]:
 > > 4) Is there really no way to avoid cluttering the disk with all that
 stuff to just build the webrtc part? Think about us builders who usually
 have a dev, hardened, alpha and stable tor-browser-bundle tree to get
 releases faster out.
 >
 > Yeah, webrtc is a beast to build.  In the short term, this ticket is
 only about the alpha channel.  In the long term, switching to rbm will
 ameliorate the issue, in that it makes better use of reusable components.
 >
 > But, your objection is noted and we'll try and think of how to improve
 the situation.

 FWIW: it is not an objection in the sense that a thing needs to get fixed
 to get the patch merged. I am just annoyed that this thing causes quite a
 big part of my hard disk filled with crap I don't want (and IMO should not
 be needed in an ideal world) :) `rbm` not really mitigates this concern
 (although, sure, I don't have to check out all of this four times).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arlolra):

 > 1) I'd like to have an enhanced commit message. At least the bug number
 should be a part.
 > 2) I heard there were snags (comment:19:ticket:19001) like the need for
 apt-get install curl pkg-config libgtk2.0-dev libglib2.0-dev. I hit that
 one, too. This should be handled in our check-prerequisites.sh script.

 Ok, see the newly attached `0001-Bug-20735-Add-snowflake-pt-to-alpha-
 Linux-builds.patch`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by arlolra):

 * cc: boklm (added)


Comment:

 > 4) Is there really no way to avoid cluttering the disk with all that
 stuff to just build the webrtc part? Think about us builders who usually
 have a dev, hardened, alpha and stable tor-browser-bundle tree to get
 releases faster out.

 Yeah, webrtc is a beast to build.  In the short term, this ticket is only
 about the alpha channel.  In the long term, switching to rbm will
 ameliorate the issue, in that it makes better use of reusable components.

 But, your objection is noted and we'll try and think of how to improve the
 situation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arlolra):

 > 3) Snowflake is not working:

 The browser proxy has not been distributed widely yet, so noone is coming
 along in time to answer your offer.  Try visiting
 https://keroserene.net/snowflake/snowflake.html in another browser
 simultaneously, or run one locally https://gitweb.torproject.org
 /pluggable-transports/snowflake.git/tree/proxy/README.md#n18

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201611R =>


Comment:

 Here is some feedback for the attached patch:

 1) I'd like to have an enhanced commit message. At least the bug number
 should be a part.
 2) I heard there were snags (comment:19:ticket:19001) like the need for
 `apt-get install curl pkg-config libgtk2.0-dev libglib2.0-dev`. I hit that
 one, too. This should be handled in our `check-prerequisites.sh` script.
 3) Snowflake is not working:
 {{{
 2016/11/25 08:28:57 BrokerChannel Error: No snowflake proxies currently
 available.
 2016/11/25 08:28:57 Failed to retrieve answer. Retrying in 10 seconds
 2016/11/25 08:29:07 Negotiating via BrokerChannel...
 Target URL:  snowflake-reg.appspot.com
 Front URL:   www.google.com
 2016/11/25 08:29:07 BrokerChannel Response:
 503 Service Unavailable
 }}}
 4) Is there really no way to avoid cluttering the disk with all that stuff
 to just build the webrtc part? Think about us builders who usually have a
 dev, hardened, alpha and stable tor-browser-bundle tree to get releases
 faster out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201611R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by serene):

 * keywords:   => TorBrowserTeam201611R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20735 [Applications/Tor Browser]: Add snowflake pt to alpha linux builds

[Tor Bug Tracker & Wiki]

#20735: Add snowflake pt to alpha linux builds
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Please see the attached.

 Reproducibility of cgo depends on a compiler that supports,

 {{{
   -gno-record-gcc-switches
   -fdebug-prefix-map=$WORK=/tmp/go-build
 }}}

 which landed in go 1.7.3

 (see
 https://github.com/golang/go/commit/5bbb98df0960f57dca73cb7640456608d4cc0917)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs