Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
-+-
 Reporter:  mcs  |  Owner:  nickm
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tbb-needs, 034-triage-20180328,  |  Actual Points:  .2
  034-removed-20180328   |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:  dgoulet =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:  nickm
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:  .2
Parent ID:| Points:  2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:  nickm
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:  .2
Parent ID:| Points:  2
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by meejah):

 (Actually, the `Dependent` / `Dependant` thing affects hidden-service
 options too)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:  nickm
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:  .2
Parent ID:| Points:  2
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by meejah):

 Thanks @teor (sorry, I saw your advice to file a new issue too late)

 I tested `getconf SocksPortLines` with an up-to-date master when I wrote
 the above (and just now) and it works as expected, so that's not an issue.

 What I think should change is:

  - Spell it `Dependant` (if this is kept at all; maybe the `*Lines` things
 can be `LineList` too, since that's what they return)
  - return "LineList" for `*Ports` from `GETINFO config/names`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:  nickm
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.3-alpha
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:  .2
Parent ID:| Points:  2
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by teor):

 * keywords:  tbb-wants 029-backport => tbb-wants
 * version:   => Tor: 0.3.0.3-alpha
 * type:  enhancement => defect


Comment:

 This is now a defect, the original feature was released in 0.3.0.3-alpha.

 Replying to [comment:22 meejah]:
 > Testing against master (9af76a9) for existing control-port using
 software, this enhancement changes the "type" given by `getinfo
 config/names` from `LineList` to `Dependent`

 > (which is also a spelling change from last release where it's
 `Dependant`).

 That was #18146.

 > Prior to now, the only thing which had the `Virtual` +
 `Dependent`/`Dependant` things was the hidden-service stuff (and only
 because order matters, according to control-spec).
 >
 > Ideally, `SocksPort` et al. would still report their type as `LineList`.
 Also, my understanding of the use of `Virtual` + `Dependent` was for
 options whose order matters. This doesn't appear to be the case here
 (unless I'm missing something?). If these *do* need to be Virtual then
 control-spec should be updated.
 >
 > txtorcon uses `getinfo config/names` to programmatically decide which
 parsers to use for options; I don't know if other control-port software
 does as well. I could of course just special-case all these new ones
 (which is the only solution currently) but the change from `LineList` ->
 `Dependant` seems unnecessary for this feature.
 >
 > (As an aside, I would personally like to see `Virtual` + `Dependent` go
 away entirely as it's the only special-case weird order-dependent thing in
 SETCONF).

 meejah also noted on IRC that "getconf SocksPortLines" doesn't work.

 This sounds a lot like #21300.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+
Changes (by meejah):

 * status:  closed => reopened
 * resolution:  implemented =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+

Comment (by meejah):

 Testing against master (9af76a9) for existing control-port using software,
 this enhancement changes the "type" given by `getinfo config/names` from
 `LineList` to `Dependent` (which is also a spelling change from last
 release where it's `Dependant`).

 Prior to now, the only thing which had the `Virtual` +
 `Dependent`/`Dependant` things was the hidden-service stuff (and only
 because order matters, according to control-spec).

 Ideally, `SocksPort` et al. would still report their type as `LineList`.
 Also, my understanding of the use of `Virtual` + `Dependent` was for
 options whose order matters. This doesn't appear to be the case here
 (unless I'm missing something?). If these *do* need to be Virtual then
 control-spec should be updated.

 txtorcon uses `getinfo config/names` to programmatically decide which
 parsers to use for options; I don't know if other control-port software
 does as well. I could of course just special-case all these new ones
 (which is the only solution currently) but the change from `LineList` ->
 `Dependant` seems unnecessary for this feature.

 (As an aside, I would personally like to see `Virtual` + `Dependent` go
 away entirely as it's the only special-case weird order-dependent thing in
 SETCONF).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * milestone:  Tor: 0.2.9.x-final => Tor: 0.3.0.x-final


Comment:

 Okay.  No backport then. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+

Comment (by gk):

 Replying to [comment:19 mcs]:
 > Replying to [comment:18 nickm]:
 > > This caused #21300, so I am leaning "no backport"
 >
 > I think "no backport" is okay because we want this for our Tor Browser
 7.0 alpha series, and we will use tor-0.3.X alpha for those releases. Is
 that correct gk?

 Yes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+

Comment (by mcs):

 Replying to [comment:18 nickm]:
 > This caused #21300, so I am leaning "no backport"

 I think "no backport" is okay because we want this for our Tor Browser 7.0
 alpha series, and we will use tor-0.3.X alpha for those releases. Is that
 correct gk?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+

Comment (by nickm):

 This caused #21300, so I am leaning "no backport"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+

Comment (by mcs):

 Replying to [comment:16 arma]:
 > mcs: I don't think you need the + signs when using the new
 {{{__SocksPort}}} / etc args?

 Hmm. I think we do, because otherwise an {{{__SocksPort}}} that is passed
 by Tor Launcher when starting tor will replace all {{{SocksPort}}}
 definitions that are present in torrc or torrc-defaults. At least that is
 what I thought I observed. I will re-test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+

Comment (by arma):

 mcs: I don't think you need the + signs when using the new __SocksPort /
 etc args?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+
Changes (by nickm):

 * milestone:  Tor: 0.3.0.x-final => Tor: 0.2.9.x-final


Comment:

 Merged to master. Should apply cleanly to 029.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  dgoulet |Sponsor:
+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
+

Comment (by mcs):

 This seems to work, at least for the scenarios that Kathy and I tested
 (thanks Nick!).

 We modified Tor Launcher to pass `+__ControlPort` and `+__SocksPort` as
 args when starting tor.
 We also removed the default `ControlPort` and `SocksPort` lines from the
 `torrc-defaults` file that ships with Tor Browser.

 With Nick's tor changes plus these Tor Launcher changes, there is no
 longer any interference with any additional control or SOCKS ports that
 users might add to their torrc. Duplicates need to be avoided though;
 otherwise tor will not start up (I think that is okay).

 The original Tor Launcher ticket is #20761.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
+

Comment (by gk):

 mcs/brade: could you take a look whether that is what we need and whether
 it is working the way we need it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
+

Comment (by arma):

 tiny typo, "for the each time"

 I didn't try running it, or hunting for other things that it forgets to
 fix, but I endorse the approach it takes!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
+
Changes (by gk):

 * cc: gk (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
+
 Reporter:  mcs |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * keywords:  tbb-wants => tbb-wants 029-backport
 * status:  accepted => needs_review
 * actualpoints:   => .2


Comment:

 My branch "feature_20956_029" adds `__SocksPort`, etc for every kind of
 port, while retaining the behavior of the old SocksPort options.  (Unlike
 the patch above, it shouldn't cause regular socksports to get dropped by
 SAVECONF.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+

Comment (by neel):

 This patch would use the SocksPort defined in the torrc unless a SocksPort
 specified at the command line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 What will happen with your patch if a user already has a SocksPort in
 their configuration?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+

Comment (by neel):

 I have created a patch which converts the ControlPort and SocksPort to
 _ControlPort and _SocksPort.

 Thank You,
 Neel Chauhan

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * points:   => 2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 See ticket #586 for a similar issue we had with Vidalia long ago: it
 wanted to put a HashedControlPassword on the command-line, but writing it
 during saveconf made no sense since it was generated fresh each time.

 The answer there was to create a separate
 {{{__HashedControlSessionPassword}}} config option. The {{{__}}} part
 makes it not get saved during saveconf:
 {{{
 /* Don't save 'hidden' control variables. */
 if (!strcmpstart(fmt->vars[i].name, "__"))
   continue;
 }}}

 Maybe some similar solution would be helpful here? "session control port"
 and "session socks port"?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-wants |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by mcs):

 * keywords:   => tbb-wants


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--+
 Reporter:  mcs   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 For Tor Browser/Tor Launcher, we have a use case where we want to pass
 ControlPort and SocksPort options on the command line (aka as program
 args) and be assured they will never be written to torrc, e.g., in
 response to a SAVECONF control port command.

 See ticket:20906#comment:7 for some background. Also, in
 ticket:20906#comment:8 nickm said:
  I think that a "Don't write this to torrc" flag might be workable, but I
 also think it's maybe less easy to implement than you might think --
 especially if it needs to work for things other than LineList options. If
 it's LineList only, it has a reasonable chance of being easy to implement.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs