Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Great, thanks for the confirmation!

 I just cherry-picked the two commits and pushed them to metrics-base
 master.  Closing.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by RaBe):

 * owner:  RaBe => metrics-team


Comment:

 I did not even touch the font of the default JavaDoc stylesheet :) But I
 agree with it being the mentioned known bug, so you can just remove the
 import line. On systems that have Deja Vu installed it will still be
 displayed, for other systems it falls back to Arial, which should be fine!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  RaBe
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  needs_review => assigned
 * owner:  metrics-team => RaBe


Comment:

 RaBe, can you comment on the fonts question above?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by karsten):

 Looks good to me.  Let's also hear what RaBe says about where fonts are
 taken from.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by iwakeh):

 Good catch!  Indeed, there is no such file or fonts.  After a small search
 this seems to be a re-occurring bug in the
 [https://bugs.openjdk.java.net/browse/JDK-8129828 jdk javadoc tool].

 Removed the line in my branch.

 (Are the fonts taken from the browser or os?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * cc: RaBe (added)
 * status:  needs_review => needs_revision


Comment:

 I didn't try this out yet, but quick question before I do: Could it be
 that the line `@import url('resources/fonts/dejavu.css');` refers to a
 file that does not exist?  At least my browser complains about that file
 being missing on RaBe's server, that is, only in the web console.  Do we
 need that file?  And if it's not available, can we even use the DejaVu
 Sans font a few lines later?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  new => needs_review


Comment:

 [https://gitweb.torproject.org/user/iwakeh/metrics-
 base.git/commit/?h=task-21376=324ffacb73e6fdc7f4c9bc931eaeec999687effe
 Here is a branch] of metrics-base with the new style included.

 Works fine locally.  Please review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by RaBe):

 Here you can download the two files you need to include in the javadocs
 builds:

 javadocs.cc-ltd.net/descriptor/stylesheet.css
 javadocs.cc-ltd.net/descriptor/tor-onion.png

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21376 [Metrics]: add javadoc metrics style

[Tor Bug Tracker & Wiki]

#21376: add javadoc metrics style
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 Add common javadoc style to metrics-base.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs