Re: [tor-bugs] #21416 [Core Tor/Tor]: util/fgets_eagain test failure on FreeBSD

[Tor Bug Tracker & Wiki]

#21416: util/fgets_eagain test failure on FreeBSD
--+---
 Reporter:  ahf   |  Owner:  ahf
 Type:  defect| Status:  closed
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by cypherpunks):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 This is a duplicate of #20988.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21416 [Core Tor/Tor]: util/fgets_eagain test failure on FreeBSD

[Tor Bug Tracker & Wiki]

#21416: util/fgets_eagain test failure on FreeBSD
--+-
 Reporter:  ahf   |  Owner:  ahf
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by ahf):

 Error correction: I meant to return the pointer to the input buffer and
 **not** `NULL`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21416 [Core Tor/Tor]: util/fgets_eagain test failure on FreeBSD

[Tor Bug Tracker & Wiki]

#21416: util/fgets_eagain test failure on FreeBSD
--+-
 Reporter:  ahf   |  Owner:  ahf
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by ahf):

 I've run the attached test case on a couple of targets thanks to some help
 by some friends on IRC.

 Linux with glibc:

 {{{
 feof()   = 0
 ferror() = 1
 retptr   = 0x7ffcefd02030
 }}}

 Linux with musl-libc (Thanks to Somasis):

 {{{
 feof()   = 0
 ferror() = 1
 retptr   = 0
 }}}

 FreeBSD:

 {{{
 feof()   = 0
 ferror() = 1
 retptr   = 0x0
 }}}

 OpenBSD (Thanks to Kramse):

 {{{
 feof()   = 0
 ferror() = 1
 retptr   = 0x7f7bfd40
 }}}

 OS X

 {{{
 feof()   = 0
 ferror() = 1
 retptr   = 0x7fff5d37d710
 }}}

 It seems like the assumption that the returned pointer value is always the
 same as the input buffer in this case is incorrect for some of our
 supported operating systems.

 Should we consider making a `tor_fgets` in our compatibility layer, which
 checks for `ferror(file) == 1` and `errno == EAGAIN` and in that case
 returns `NULL`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21416 [Core Tor/Tor]: util/fgets_eagain test failure on FreeBSD

[Tor Bug Tracker & Wiki]

#21416: util/fgets_eagain test failure on FreeBSD
--+-
 Reporter:  ahf   |  Owner:  ahf
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 The `util/fgets_again` test currently fails on FreeBSD with the following
 error:

 {{{
 $ ./src/test/test util/fgets_eagain
 util/fgets_eagain:
   FAIL src/test/test_util.c:3969: assert(retptr OP_EQ buf): 0x0 vs
 0x7efe49dea1f0
   [fgets_eagain FAILED]
 1/1 TESTS FAILED. (0 skipped)
 }}}

 This causes the FreeBSD build-bot to report failure on every commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs