Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-09-15 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt continuous-   |  implemented
  integration static-analysis|  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Merged the patch here, with followups.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-09-12 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt continuous-   |  Actual Points:
  integration static-analysis|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I've also created #23491 to handle "automate this."

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-09-12 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt continuous-   |  Actual Points:
  integration static-analysis|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Okay; I've tried to minimize false positives.  `scan-build-032` is ready
 for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-09-12 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt continuous-   |  Actual Points:
  integration static-analysis|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I've two bugs so far: #23488 and #23487.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-09-12 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  task | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt continuous-   |  Actual Points:
  integration static-analysis|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-07-07 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
-+-
 Reporter:  teor |  Owner:
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt continuous-   |  Actual Points:
  integration static-analysis|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:   => technical-debt continuous-integration static-analysis
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-02-16 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
--+--
 Reporter:  teor  |  Owner:
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 How did it go?
 (Can you post the log somewhere?)

 Perhaps we could tune it so the scanners that yield a large number of
 false positives are excluded?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-02-16 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
--+--
 Reporter:  teor  |  Owner:
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 Running scan-build now.  For reference there's a script in ./scripts/test
 /scan-build.sh , but the false positive rate is pretty high.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21482 [Core Tor/Tor]: Run clang-scan on tor master

2017-02-15 Thread Tor Bug Tracker & Wiki
#21482: Run clang-scan on tor master
--+--
 Reporter:  teor  |  Owner:
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:|
--+--
 I think it might have caught #21471, maybe we should run it on 0.3.0 or
 0.3.1?

 But that requires someone to actually take the time to do it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs