Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by ahf):

 That's correct.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by atagar):

 Ahhh, gotcha. So just to be clear: it's not actually being exposed on the
 DirPort yet?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by nickm):

 atagar: It isn't actually used yet; this ticket is just for the backend
 code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by atagar):

 Neat! Friendly reminder that this needs to be added to the dir-spec or it
 doesn't exist. ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by nickm):

 Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 I believe I've been over everything you have commented on in the reviews
 now. We've postponed merging the test functions into a simplified function
 that tests all backends and we have postponed doing coverage "hints" in
 the code.

 I've added a clean-up patch of some of the Zstandard code with regards to
 flushing the internal buffer in a more eager manner.

 Let me know if this looks acceptable for merge and I'll happily do the
 squashing as well (whatever you find easiest!)

 Note that this is build on the comments already made in both
 https://gitlab.com/ahf/tor/merge_requests/1 and
 https://gitlab.com/ahf/tor/merge_requests/2 - Gitlab seems to hide that a
 bit.

 Once this code lands we can close both #21662, #21663 and #21664.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Looks good!  I've made some initial comments and asked some questions.
 Also, I should take another pass or two over this code when I'm a little
 less tired, and think about the pointer arithmetic very carefully.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by ahf):

 * status:  accepted => needs_review


Comment:

 Ready for review: https://gitlab.com/ahf/tor/merge_requests/2/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
+--
 Reporter:  ahf |  Owner:  ahf
 Type:  task| Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by ahf):

 Starting to track the cleaned up commits in:
 https://gitlab.com/ahf/tor/merge_requests/2

 Currently LZMA support is available - Zstandard coming up.

 Note that this code depends upon the code that is currently being reviewed
 as part of #21663.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
---+
 Reporter:  ahf|  Owner:  ahf
 Type:  task   | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
---+
 Reporter:  ahf|  Owner:  ahf
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * owner:   => ahf
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
--+
 Reporter:  ahf   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  TorCoreTeam201703
Actual Points:|  Parent ID:
   Points:  2 |   Reviewer:
  Sponsor:  Sponsor4  |
--+
 Add support for the compression schemes needed to implement prop#278.

 See: http://facebook.github.io/zstd/ and http://7-zip.org/sdk.html for the
 respective libraries.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs