Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:11 cypherpunks]:
 > Can't you just leave people who use "High" security? This popup is very
 annoying.
 There's a related bug on Mozilla's bug tracker about not showing this
 popup until there's some user input, please don't mess up other tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Can't you just leave people who use "High" security? This popup is very
 annoying.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. This is commit 1182bee9789a632f374f0a6d3ed90f21af1e37c5 on `tor-
 browser-52.1.0esr-7.0-2` now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Here is a revised patch:
  https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21778-02&id=eee986e3824e8e872dd3cb38c2f6bf2a16f86d7b
 (it includes a second indentation fix too).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Looks good to me, too. Just one nit:
 {{{
 +try {
 +  browser = aSubject.QueryInterface(Ci.nsIBrowser);
 +   } catch (e) {}
 }}}
 (indentation).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:5 mcs]:
 > It took a lot longer than we expected to find a working solution, but
 here is a fix for review:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21778-01&id=04b228b078c98cabedc0ccc179d627d693884a42

 Nice work! Looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Hrr, this annoying popup again! Leave it for dumb users on Low Security
 only!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, TorBrowserTeam201704R|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-e10s => ff52-esr, tbb-7.0
 -must-alpha, tbb-e10s, TorBrowserTeam201704R
 * status:  new => needs_review


Comment:

 It took a lot longer than we expected to find a working solution, but here
 is a fix for review:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21778-01&id=04b228b078c98cabedc0ccc179d627d693884a42

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mcs):

 * keywords:  ff52-esr => ff52-esr, tbb-7.0-must-alpha


Comment:

 This is a regression. Unless we plan to disable e10s, we should try to fix
 this for the alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mcs):

 * cc: brade, mcs (added)


Comment:

 When I tested on OSX, disabling e10s mode made the prompt work again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21778 [Applications/Tor Browser]: Canvas prompt is not showing up anymore in Tor Browser based in ESR52

[Tor Bug Tracker & Wiki]

#21778: Canvas prompt is not showing up anymore in Tor Browser based in ESR52
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff52-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Going to https://github.com gives regularly the canvas prompt asking users
 what to do with a website wanting to access the canvas.

 This is not happening anymore with an ESR52 based Tor Browser. Other sites
 are probably affected as well.

 The blocking note is still visible on the browser console, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs