Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
---+
 Reporter:  davidwf|  Owner:  aagbsn
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:
Component:  Metrics/Torflow|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  chelseakomlo, tom  |Sponsor:
---+
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 davidwf: thanks for this patch!

 In general:

 Why did you downgrade from SQLAlchemy 0.7.10 to 0.7.8?
 Whichever way you choose to go, please find all instances of
 SQLAlchemy-0.7.* and make them consistent.

 For future patches, it is ok to provide a branch and use multiple commits
 - in fact, we prefer it!

 In particular, it is nice if whitespace changes are in a separate commit
 to functional changes.

 In particular:

 In setup.sh and setup_cron.sh:

 readlink -f works with gnu readlink, but not with BSD readlink. It is
 possible to install BSD readlink on Linux, and GNU readlink on BSD or
 macOS. So we can't depend on uname, we should just try basename if
 readlink doesn't work here:
 {{{
 +# readlink -f does not work on Mac
 +if [ `uname` != "Darwin" ]
 +then
 +  SCANNER_DIR=$(readlink -f "$SCANNER_DIR")
 +fi
 }}}
 Also, let's use the same code in all the scripts to do this, for
 consistency.

 Some OSs only have a non-versioned python (e.g. macOS), so we should fall
 back to "which python" here:
 {{{
 +PYTHON=$(which python2.7 || which python2.6)
 }}}

 In stop_scan.sh:

 This is a dangerous strategy if the process has already died, and its PID
 is being used by something else. Can we check the process has the right
 name in a cross-platform way?
 {{{
 kill -9 `head -1 $PIDFILE` && rm $PIDFILE
 }}}

 You may also be better making the parent scanner script Tor's
 __OwningControllerProcess, so tor exits automatically when the script
 exits. But you'll just have to kill the bwauthority child processes.

 Please don't copy environmental variables like this:
 {{{
 +SCANNERS_PER_TOR_COUNT=4
 +TOR_COUNT=2
 +SCANNER_COUNT=$(($SCANNERS_PER_TOR_COUNT * $TOR_COUNT + 1))
 }}}

 It makes it easy for them to get out of sync with the launch script.
 Also, if someone changes the variables, then stops the scanners, some will
 be left over.
 Instead, why not do:
 {{{
 for PIDFILE in ./data/scanner.*/bwauthority.pid
 }}}
 and the same for the tor instances.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
---+-
 Reporter:  davidwf|  Owner:  aagbsn
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Torflow|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  chelseakomlo, tom  |Sponsor:
---+-

Comment (by chelseakomlo):

 Changing this to merge ready. tom, feel free to change to needs_review if
 you see anything else that needs revision.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
---+-
 Reporter:  davidwf|  Owner:  aagbsn
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Torflow|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  chelseakomlo, tom  |Sponsor:
---+-
Changes (by chelseakomlo):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
---+--
 Reporter:  davidwf|  Owner:  aagbsn
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Torflow|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  chelseakomlo, tom  |Sponsor:
---+--

Comment (by chelseakomlo):

 This seems good to me as well (I tested this on macOS).

 If virtualenv is used, #20466 shouldn't be an issue (I believe).

 #20454 should also be addressed with this patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
---+--
 Reporter:  davidwf|  Owner:  aagbsn
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Torflow|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  chelseakomlo, tom  |Sponsor:
---+--
Changes (by tom):

 * cc: tom (added)
 * reviewer:  chelseakomlo, tjr => chelseakomlo, tom


Comment:

 This seems good, but I'm wondering if it conflicts or subsumes some
 outstanding work in #20466, #20452, #20454, #20452

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
---+--
 Reporter:  davidwf|  Owner:  aagbsn
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Torflow|Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  chelseakomlo, tjr  |Sponsor:
---+--
Changes (by chelseakomlo):

 * reviewer:  chelseakomlo, teor => chelseakomlo, tjr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
+--
 Reporter:  davidwf |  Owner:  aagbsn
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/Torflow |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  chelseakomlo, teor  |Sponsor:
+--

Comment (by chelseakomlo):

 I will test functionality, it would be good to have teor or someone who
 runs a bwauth to give a second opinion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
+--
 Reporter:  davidwf |  Owner:  aagbsn
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/Torflow |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  chelseakomlo, teor  |Sponsor:
+--
Changes (by chelseakomlo):

 * reviewer:   => chelseakomlo, teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
-+--
 Reporter:  davidwf  |  Owner:  aagbsn
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Torflow  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by davidwf):

 * status:  new => needs_review
 * cc: davidwf (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
-+
 Reporter:  davidwf  |  Owner:  aagbsn
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Torflow  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by davidwf):

 Gzipped patch attached + github branch here:
 https://github.com/davidfaulkner12/bwauth/tree/nicedev

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21846 [Metrics/Torflow]: BwAuthority can't be run out of the box without manual work

[Tor Bug Tracker & Wiki]

#21846: BwAuthority can't be run out of the box without manual work
-+
 Reporter:  davidwf  |  Owner:  aagbsn
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Torflow  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 Currently the bwauthority is quite out of date with the current python
 ecosystem and doesn't play nice in a dev environment.

 The submitted patch makes the following updates:

 1) Removes the cron setup to a separate script (so running setup.sh
 doesn't alter your crontab)
 2) Changes the shell script to use a modern pip instead of peep (peep is
 deprecated and hash checking is incorporated into pip as of version 8.0
 (https://pypi.python.org/pypi/peep/)
 3) Updated dependencies as far as possible (Elixer's last version is 0.7.1
 and is only compatible with SQLAlchemy <= 0.7.8, obvious future
 enhancement to move away from Elixir)
 4) Added a convenience script to kill all the spun up processes
 5) Updated the ReadMe and the .gitignore to reflect these changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs