[tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
---+
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  new
 Priority:  Very High  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  tor-hs, prop224
Actual Points: |  Parent ID:  #20657
   Points:  3  |   Reviewer:
  Sponsor:  SponsorR-must  |
---+
 In order to establish an end-to-end crypto channel on a rendezvous
 circuit, we need a new API that setups the `crypt_path_t` object on the
 circuit from the key material computed between the client and service.
 This API has to be for both service and client side.

 Because the service implementation in #20657 is being done before client,
 setting parent ID to that ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  assigned
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  3
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  new => assigned
 * owner:   => asn
 * parent:  #20657 => #21888


Comment:

 If we can make it happen before 032, *great*, else no biggy. Changing
 parent ticket to the "prop224 groundwork" ticket since this is needed by
 #20657 and can be merged safely upstream without affecting tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  assigned
 Priority:  Very High|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  3
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  3
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  assigned => needs_review
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


Comment:

 OK pushed branch `bug21859` to my repo with initial code for this ticket.

 Most of the commits are refactoring stuff and preparing for not-done-
 before unittests. Commit `32ffaedf9` actually does most of the work.

 Please find gitlab merge request here:
 https://gitlab.com/asn/tor/merge_requests/14/diffs

 Moving this to 0.3.2 milestone since it requires all the hs_ident stuff
 that are gonna be merged in 0.3.2 . If we wanted to merge stuff earlier,
 we could split the branch into a 0.3.1 branch that only does legacy stuff,
 and then merge the 0.3.2 stuff later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  9
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * points:  3 => 9


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  9
 Reviewer:  dgoulet  |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 I commented. Nothing major, mostly naming and comments. Good stuff!!!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  assigned
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  9
 Reviewer:  dgoulet  |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  needs_revision => assigned


Comment:

 OK pushed branch `bug21859_v2`, which includes all of David's review
 fixes.

 Putting ticket in neutral state. Not sure if this should be in
 `needs_review` as it's 0.3.2 material and part of #21888.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
-+
 Reporter:  dgoulet  |  Owner:  asn
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  9
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  assigned => needs_review
 * reviewer:  dgoulet => nickm


Comment:

 This is a big piece of groundwork for prop224 service implementation
 #20657.

 This branch contains basically two things. It adds hidden service
 identifiers (`hs_ident.{c|h}`) which is the new and improved `rend_data`
 concept. Then, it introduces an API/ABI for the e2e encryption of
 client<->service.

 Tor branch: `ticket21859_032_01`
 Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/29

 The prop224 train has started for 032! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
--+
 Reporter:  dgoulet   |  Owner:  asn
 Type:  enhancement   | Status:
  |  needs_revision
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-19  |  Actual Points:
Parent ID:  #21888| Points:  9
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Review done; I didn't find any terrible bugs, but I think there are some
 style and safety issues we should fix before we move on.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
--+
 Reporter:  dgoulet   |  Owner:  asn
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-19  |  Actual Points:
Parent ID:  #21888| Points:  9
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Everything has been addressed/commented. Let's go back in needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21859 [Core Tor/Tor]: prop224: Rendezvous circuit e2e crypto

[Tor Bug Tracker & Wiki]

#21859: prop224: Rendezvous circuit e2e crypto
--+
 Reporter:  dgoulet   |  Owner:  asn
 Type:  enhancement   | Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
  |  implemented
 Keywords:  tor-hs, prop224, review-group-19  |  Actual Points:
Parent ID:  #21888| Points:  9
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Squashed as ticket21859_032_01_squashed, then small changes added.  Then
 merged.  Hooray!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs