Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+

Comment (by dgoulet):

 Replying to [comment:9 nickm]:
 > Sure; merged!
 >
 > Question -- how's coverage here?

 Very low... *but* the good news is that I'm almost at 100% with prop224
 for loading/configure service which uses heavily those functions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Sure; merged!

 Question -- how's coverage here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:7 dgoulet]:
 > Replying to [comment:6 asn]:
 > > OK this last branch made the changes slightly clearer.
 > >
 > > Changes LGTM.
 > >
 > > One thing I did not understand is why the validation function is not
 called by `rend_service_check_dir_and_add()`, and instead we have to call
 both functions in a row.
 >
 > This changes heavily in prop224 refactoring (#21979) so it's not in that
 function... Would you prefer having it there and then modified in the
 refactoring?

 Nah, I think it's fine. It's just two occurrences for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+

Comment (by dgoulet):

 Replying to [comment:6 asn]:
 > OK this last branch made the changes slightly clearer.
 >
 > Changes LGTM.
 >
 > One thing I did not understand is why the validation function is not
 called by `rend_service_check_dir_and_add()`, and instead we have to call
 both functions in a row.

 This changes heavily in prop224 refactoring (#21979) so it's not in that
 function... Would you prefer having it there and then modified in the
 refactoring?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+

Comment (by asn):

 OK this last branch made the changes slightly clearer.

 Changes LGTM.

 One thing I did not understand is why the validation function is not
 called by `rend_service_check_dir_and_add()`, and instead we have to call
 both functions in a row.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+

Comment (by dgoulet):

 I made two commits now, one that only creates the validate function
 (minimal changes to the code) and then a second commit that fixes the
 duplication in `rend_add_service()` and make the service configure process
 use both functions correctly.

 See branch: `ticket21978_031_02`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+

Comment (by dgoulet):

 Thanks for review!

 I've responded and added a fixup commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+

Comment (by asn):

 Did an initial review but there was lots of moving&editing in the same
 commit which confused me a bit. I should probably look at it again/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:  asn  |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #21888   | Points:  0.2
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  new => needs_review


Comment:

 Tor code: `ticket21978_031_01`
 Gitlab: https://gitlab.com/dgoulet/tor/merge_requests/26

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21978 [Core Tor/Tor]: hs: Decouple adding and validating a service

[Tor Bug Tracker & Wiki]

#21978: hs: Decouple adding and validating a service
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  tor-hs, prop224
Actual Points: |  Parent ID:  #21888
   Points:  0.2|   Reviewer:
  Sponsor:  SponsorR-must  |
---+
 One commit that splits the `rend_add_service()` function into two
 functions. One actually adding the service to the global list and the
 second one to validate the service thus adding a new function:
 `rend_validate_service()`

 We need this for prop224 code that will in two steps validate and then add
 the service when loading a service from configuration.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs