[tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff52-esr, tbb-e10s
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Using a non-en-US locale does not show the "request English language web
 pages"-prompt anymore with the switch to 7.0a3. I have not looked closer
 but I guess the progress listener is broken due to e10s.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  ff52-esr, tbb-e10s => ff52-esr, tbb-e10s, tbb-7.0-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must-|  Actual Points:
  alpha  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff52-esr, tbb-e10s, tbb-7.0-must => ff52-esr, tbb-e10s,
 tbb-7.0-must-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s,  |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Why is this prompt at all? Shouldn't it ask the opposite "Do you want to
 request web pages of your locale (reduces antifingerprinting protection)?"
 if should?
 (Never seen that switching GUI language affects some program's behavior.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * cc: arthuredelstein (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706R, tbb-7.0-issues, tbb-|
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:
 ff52-esr, tbb-e10s, tbb-7.0-must, TorBrowserTeam201706,
 tbb-7.0-issues, tbb-regression
 =>
 ff52-esr, tbb-e10s, tbb-7.0-must, TorBrowserTeam201706R,
 tbb-7.0-issues, tbb-regression
 * status:  new => needs_review


Comment:

 Here's a patch for review:
 https://github.com/arthuredelstein/torbutton/commit/21999

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706R, tbb-7.0-issues, tbb-|
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:9 arthuredelstein]:
 > Here's a patch for review:
 > https://github.com/arthuredelstein/torbutton/commit/21999

 The code looks okay but Kathy and I have a couple of questions:
 * Why is the delay before showing the prompt only imposed for about:tor?
 * The old code only showed the prompt when the user accessed an HTTP page.
 The new code will show it at startup on about:tor, which seems like a less
 friendly "first run" experience (mostly because the prompt will cover up a
 lot of the about:tor content). Are we okay with this change in behavior?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706R, tbb-7.0-issues, tbb-|
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 mcs]:
 > Replying to [comment:9 arthuredelstein]:
 > > Here's a patch for review:
 > > https://github.com/arthuredelstein/torbutton/commit/21999
 >
 > The code looks okay but Kathy and I have a couple of questions:
 > * Why is the delay before showing the prompt only imposed for about:tor?
 > * The old code only showed the prompt when the user accessed an HTTP
 page. The new code will show it at startup on about:tor, which seems like
 a less friendly "first run" experience (mostly because the prompt will
 cover up a lot of the about:tor content). Are we okay with this change in
 behavior?

 No. I think we should try to get it going the way it was implemented in
 #18019. Or at least the patch should give a similar experience.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706R, tbb-7.0-issues, tbb-|
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Makes sense to me. Here's a different patch that I think preserves the
 behavior from before. One problem is that with e10s, the
 nsIWebProgressListener no longer delays the request. But "http-on-modify-
 request" observers correctly delays the request until their observe()
 function returns, so I am using one of those instead.

 The only drawback I see with this approach is that sometimes Firefox makes
 a background http request (such as checking for updates) and I'm not sure
 whether or not we want to show the prompt when that happens, and what the
 criteria should be for ignoring such requests.

 https://github.com/arthuredelstein/torbutton/commit/21999+2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706, tbb-7.0-issues, tbb- |
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:
 ff52-esr, tbb-e10s, tbb-7.0-must, TorBrowserTeam201706R,
 tbb-7.0-issues, tbb-regression
 =>
 ff52-esr, tbb-e10s, tbb-7.0-must, TorBrowserTeam201706,
 tbb-7.0-issues, tbb-regression


Comment:

 Replying to [comment:12 arthuredelstein]:
 > Makes sense to me. Here's a different patch that I think preserves the
 behavior from before. One problem is that with e10s, the
 nsIWebProgressListener no longer delays the request. But "http-on-modify-
 request" observers correctly delays the request until their observe()
 function returns, so I am using one of those instead.

 Sounds like a good idea. While testing this for a while I found two
 possible outcomes both of them being suboptimal:

 1) The dialog does not get shown at all. This happens when the Torbutton
 update check is the first request captured by the observer. Subsequent
 surfing to different websites does not bring the dialog up either. Not
 sure why that is happening.

 2) I get the dialog shown with the `about:tor` page (triggered by the
 updater check). This is pretty confusing as it boils down to a modal
 dialog during the start-up process, a thing we should avoid if possible.

 I think what we could do is to use the `setTimeout()` call which we need
 for the homepage case anyway and apply it generally. There should not be
 any automatic requests on start-up besides the update checks for
 extensions and the browser itself and the Torbutton version check. As
 those happen often on start-up and there is no need to show localized web
 content in a response basically exempting those requests seems fine to me.

 > The only drawback I see with this approach is that sometimes Firefox
 makes a background http request (such as checking for updates) and I'm not
 sure whether or not we want to show the prompt when that happens, and what
 the criteria should be for ignoring such requests.

 The prompt is shown once. And it is not really important for background
 update requests/checks as the response content displayed in the browser
 (if it is displayed at all) is not dependent on the `Accept-Language`
 header. So it seems fine to me we can ignore this kind of requests.

 > https://github.com/arthuredelstein/torbutton/commit/21999+2

 Apart from the suggestion above there are some nits:

 {{{
 // add a web progress listener that will show a "request English
 language
 // web pages?" prompt the first time an http or https page is opened.
 }}}
 But we have no web progress listener anymore.
 {{{
 +function torbutton_http_connection_observed(aRequest, aData) {
 +// If we are loading an HTTP page, show the
 +  // "request English language web pages?" prompt.
 }}}
 Indentation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706, tbb-7.0-issues, tbb- |
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 As you don't provide UI to change this setting later, you might move it to
 installer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  TorBrowserTeam201706, tbb-7.0-issues, tbb- |
  regression |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 #22659 is related to that feature.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  tbb-7.0-issues, tbb-regression,|
  TorBrowserTeam201707R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:
 ff52-esr, tbb-e10s, tbb-7.0-must, tbb-7.0-issues, tbb-regression,
 TorBrowserTeam201707
 =>
 ff52-esr, tbb-e10s, tbb-7.0-must, tbb-7.0-issues, tbb-regression,
 TorBrowserTeam201707R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:13 gk]:

 Thanks for the review and testing. Here is a revised branch, with the same
 patch revised to trigger the prompt only when a request is launched from a
 content "load context". I tested this new version with update requests and
 various about: pages and the prompt was not triggered.

 I also noticed that some homepage URLs were not being properly detected by
 function `torbutton_is_homepage_url(aURI)`. So I added a second patch to
 this new branch to try to take care of that problem.

 https://github.com/arthuredelstein/torbutton/commits/21999+3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21999 [Applications/Tor Browser]: The "request English language web pages"-prompt is not working in 7.0a3

[Tor Bug Tracker & Wiki]

#21999: The "request English language web pages"-prompt is not working in 7.0a3
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,|  Actual Points:
  tbb-7.0-issues, tbb-regression,|
  TorBrowserTeam201707R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks, looks good to me. Merged to `master` (commit
 90c35ef999de8b9ee09876f5772a2a728d2bafc1 and
 8af90b3222529f9b863229a32dd62b2f9f941d19).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs