Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 squashed and merged; thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Actually probably better in `merge_ready` since nickm was the reviewer
 here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Last fixup commits fixing the comment about AllowSingleHop situation.

 Branch: `ticket22060_031_01`
 Spec: `ticket22060_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+

Comment (by nickm):

 I argue more about 5df1535dc on the ticket.  I still think that branch
 should always be taken.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:  nickm |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review
 * reviewer:   => nickm


Comment:

 I've addressed everything. As for this comment (which I can not reply on
 Gitlab, probably a bug):

  If this is a separate bug, I think maybe this should have its own changes
 file, and its own ticket number?

 This bug was introduced with the cleanup because we get rid of the
 `*ListenAddress` interface. So because it was never released, I didn't go
 for a change file nor ticket. It's basically part of this patchset like
 fixing a test. Not good?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Thanks!  I've reviewed it on github.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by dgoulet):

 Gitlab merge request: https://gitlab.com/dgoulet/tor/merge_requests/28

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by dgoulet):

 (I'm weirdly always happy about code removal sometimes :)

  16 files changed, 203 insertions(+), 897 deletions(-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * owner:   => dgoulet
 * status:  needs_review => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  new => needs_review
 * keywords:  config, easy => config
 * points:  0.2 => 0.5


Comment:

 Some options are more tricky to remove! The branch I present removes the
 following.

  * `AllowInvalidNodes`
  * `AllowSingleHopCircuits`
  * `AllowSingleHopExits`
  * `ExcludeSingleHopRelays`
  * `FastFirstHopPK`
  * `CloseHSClientCircuitsImmediatelyOnTimeout`
  * `CloseHSServiceRendCircuitsImmediatelyOnTimeout`
  * `WarnUnsafeSocks`
  * `{Control,DNS,Dir,Socks,Trans,NATD,OR}ListenAddress`

 Two are still deprecated at this point. `AllowDotExit` is a bit more
 complex and would benefit from its own ticket once this is merged. The
 second is `ClientDNSRejectInternalAddresses` that is still used for test
 networks (see ticket in description).

 For `AllowSingleHopExits` a very small patch is needed to the dir-
 spec.txt.

 Spec: `ticket22060_01`
 Tor: `ticket22060_031_01`

 Extra points! There was a bug that got exposed with the removal of
 `ORListenAddress`. Within `server_mode()`, we used to look at `ORPort_set
 || ORListenAddress` where `ORPort_set` is set in `parse_ports()`.

 However, `options_validate()` is using `server_mode()` at the start to
 check if we need to look at the uname but then the `ORPort_set` is unset
 at that point because the port parsing is just after. Thus, there is an
 extra commit that fixes that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config, easy  |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+

Comment (by dgoulet):

 Replying to [comment:1 nickm]:
 > BTW, let's remove only one option per commit, in case we need to revert.
 :)

 Yes this is what I meant with: "We should OBSOLETE() them and remove the
 associated code. Let's do one option removal per commit." :D

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  config, easy  |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 BTW, let's remove only one option per commit, in case we need to revert.
 :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--+
 Reporter:  dgoulet   |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  config, easy
Actual Points:|  Parent ID:
   Points:  0.2   |   Reviewer:
  Sponsor:|
--+
 We have a set of deprecated options in `src/or/config.c` in the
 `option_deprecation_notes_` array.

 We should `OBSOLETE()` them and remove the associated code. Let's do one
 option removal per commit.

 #21522 and #21031 asks to not get rid of
 `ClientDNSRejectInternalAddresses` so let's not for this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs