Re: [tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201707R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 That should not happen as the default in that case at least is set to
 `addons://list/extension` (see: https://dxr.mozilla.org/mozilla-
 esr52/source/toolkit/mozapps/extensions/content/extensions.js#207). This
 is commit b3989f16138112084c008f89d54ecbe9cd4804d7 on `tor-
 browser-52.2.0esr-7.5-1`. I guess we could think about backporting it to
 the stable branch as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201707R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 r=brade, r=mcs
 This change is fine. The spinning icon problem is a little annoying but
 something we can probably live with as long as it does not happen when
 about:addons is opened for the very first time. On the browser console I
 see:
 {{{
 13:13:31.058 NS_ERROR_FAILURE: Root node doesn't exist for 'discover' view
 1 extensions.js:852
 gViewController.loadViewInternal
 chrome://mozapps/content/extensions/extensions.js:852:13
 gViewController.loadInitialView
 chrome://mozapps/content/extensions/extensions.js:822:5
 initialize chrome://mozapps/content/extensions/extensions.js:238:3
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201707R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  TorBrowserTeam201707 => TorBrowserTeam201707R
 * status:  new => needs_review


Comment:

 See `bug_22073_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_22073_v2&id=b3989f16138112084c008f89d54ecbe9cd4804d7)
 which is up for review.

 Not sure if we want to deal with users that have the GetAddons pane
 already selected. They will now see a spinning icon on about:addons until
 they select any of the other remaining options on the page.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201707  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: justJanne (added)
 * keywords:   => TorBrowserTeam201707


Comment:

 Resolved #22900 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 We don't know which extensions Mozilla is showing to users and we are
 generally of the opinion that Tor Browser should not used with additional
 extensions. We can make it harder for users to shoot themselves in the
 foot by just hiding the GetAddons pane with
 `extensions.getAddons.showPane` set to `false`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs