[tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #13339
   Points:  .3|   Reviewer:
  Sponsor:  Sponsor4  |
--+


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13339| Points:  .3
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by nickm):

 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * status:  accepted => needs_review
 * keywords:   => TorCoreTeam201705
 * actualpoints:   => .3


Comment:

 See my dirspec branch `prop140_completed`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by catalyst):

 Looks reasonable to me at first glance.  I haven't exhaustively checked
 how faithfully the new dir-spec.txt reflects the prop140 content.  I just
 noticed that the following diff chunk seems like a possible typo, though.

 {{{
 @@ -216,7 +217,7 @@ Status: Accepted

The following parameters govern how relays and clients use this
 protocol.

 - min-consensuses-age-to-cache-for-diff
 +b min-consensuses-age-to-cache-for-diff
 (min 0, max 744, default 6)
   max-consensuses-age-to-cache-for-diff
 (min 0, max 8192, default 72)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Generally looks good. Two questions:

 1) This patch marks prop140 as closed, but do we support the `/tor/status-
 vote/current/consensus/diff//.z` paths already?

 2) This is in the nitpick category. Do we want to change the delimiter in
 `X-Or-Diff-From-Consensus` to use "," and optionally " " like in the rest
 of HTTP?

 Catalyst also commented on a possible typo above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 Replying to [comment:4 ahf]:
 > Generally looks good. Two questions:
 >
 > 1) This patch marks prop140 as closed, but do we support the `/tor
 /status-vote/current/consensus/diff//.z` paths already?

 Not until we merge one of the branches in #22149 ; I'm not planning to
 merge this branch until #22149 is done

 > 2) This is in the nitpick category. Do we want to change the delimiter
 in `X-Or-Diff-From-Consensus` to use "," and optionally " " like in the
 rest of HTTP?

 Huh. I think right now it allows either in the code; I guess we should
 change the spec to match.

 > Catalyst also commented on a possible typo above.

 Agreed, will fix before merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by ahf):

 The code does:

 {{{
 3661   smartlist_split_string(hex_digests, hdr, " ",
 3662  SPLIT_SKIP_SPACE|SPLIT_IGNORE_BLANK, -1);
 }}}

 So no ",".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 ok.  IMO it's fine to have it start accepting commas, since currently
 nothing sends more than one X-Or-Diff-From-Consensus value anyway.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 branch updated; I should do a corresponding update for the comma issue
 once the other prop#278 and prop#140 stuff is merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22149 [Core Tor/Tor]: prop140: Update dir-spec with prop140 protocols

[Tor Bug Tracker & Wiki]

#22149: prop140: Update dir-spec with prop140 protocols
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  TorCoreTeam201705  |  Actual Points:  .3
Parent ID:  #13339 | Points:  .3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 squashed and merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs