Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * cc: ahf (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by yawning):

 https://hg.python.org/cpython/file/tip/Lib/http/client.py#l1172

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by Sebastian):

 Ok, my jessie stuff sat behind a proxy doing who knows what. So the
 behaviour I'm seeing on jessie is the same as arma, at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by yawning):

 The code MUST respond to `.z` GETs/`Accept-Encoding: identity` requests
 with a response consisting of zlib compressed payload, because the
 identity transform of a `.z` file is a `.z` file, not plaintext.

 The code MAY responmd to `.z` GETs/`Accept-Encoding:` that does not
 include `identity` requests by doing an extra compression pass on the `.z`
 payload.  Alternatively, it could return an error (`406 Not Acceptable`
 seems like the right one?).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by yawning):

 or/directory.c:directory_handle_command_get()
 {{{
   if ((header = http_get_header(headers, "Accept-Encoding: "))) {
 compression_methods_supported = parse_accept_encoding_header(header);
 tor_free(header);
   } else {
 compression_methods_supported = (1u << NO_METHOD);
 if (zlib_compressed_in_url)
   compression_methods_supported |= (1u << ZLIB_METHOD);
   }
 }}}

 That's at least one of the problems.  If `zlib_compressed_in_url` is set,
 the data to be transferred before `Accept-Encoding: ` is taken into
 account should be zlib compressed payload.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by Sebastian):

 Note that the headers aren't necessarily relevant, my jessie's headers are
 these (according to a wget to a nc -l arma set up for me):

 {{{
 GET /foo.z HTTP/1.1
 User-Agent: Wget/1.16 (linux-gnu)
 Accept: */*
 Host: 128.31.0.47:5
 Cache-Control: max-age=259200
 Connection: keep-alive
 }}}

 yet that wget fetches an uncompressed file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 My wget on jessie (the one that behaves ok) is sending these headers:
 {{{
 GET /tor/status-vote/current/consensus.z HTTP/1.1
 User-Agent: Wget/1.16 (linux-gnu)
 Accept: */*
 Host: 128.31.0.39:9131
 Connection: Keep-Alive
 }}}

 I assume the other wgets (the ones that misbehave) are setting an Accept-
 Encoding header.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 I've left moria1 running the shiny new code (git commit 2e4f3b36), so
 others can make progress on the ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 {{{
  Content-Encoding: identity
  network-status-version 3
  vote-status consensus
  consensus-method 25Y
  that does not look like the identity encoding of a .z file to me
  so tor is spitting back uncompressed data at me
  wget is setting `Accept-Encoding: identity`
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 {{{git show 1bc2}}} has all the keywords I would expect to search for.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus behaves unpredictably strange

[Tor Bug Tracker & Wiki]

#22206: Fetching compressed consensus behaves unpredictably strange
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 This morning, we had this fun notice from doctor:

 {{{
 ERROR: Unable to retrieve the consensus from moria1
 (http://128.31.0.39:9131/tor/status-vote/current/consensus.z): Error -3
 while decompressing data: incorrect header check
 ERROR: Unable to retrieve the vote from moria1
 (http://128.31.0.39:9131/tor/status-vote/current/authority.z): Error -3
 while decompressing data: incorrect header check
 }}}

 The file from that hour is available at
 http://seul.org/~arma/consensus-20170508.z.

 The next weird thing is that using three different wget versions from
 different platforms, using

 {{{
 wget http://128.31.0.39:9131/tor/status-vote/current/consensus.z
 }}}

 to fetch a consensus from moria gives an uncompressed file. yawning and I
 can reproduce that, arma can not. Something fishy seems to be going on?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs