Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-09 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  new => assigned
 * owner:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-09 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => regression


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  assigned => needs_review


Comment:

 Possible fix available in
 https://gitlab.com/ahf/tor/merge_requests/10/diffs

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Why this approach in particular, and not something more like:
 {{{
 diff --git a/src/or/directory.c b/src/or/directory.c
 index 67c28e1f3e22e4..c1db40ef22cfc2 100644
 --- a/src/or/directory.c
 +++ b/src/or/directory.c
 @@ -3516,8 +3516,9 @@ directory_handle_command_get,(dir_connection_t
 *conn, const char *headers,
  tor_free(header);
} else {
  compression_methods_supported = (1u << NO_METHOD);
 -if (zlib_compressed_in_url)
 -  compression_methods_supported |= (1u << ZLIB_METHOD);
 +  }
 +  if (zlib_compressed_in_url) {
 +compression_methods_supported |= (1u << ZLIB_METHOD);
}

/* Remove all methods that we don't both support. */
 }}}

 (This is a question, not a suggestion -- I'm trying to understand what the
 pros and cons of the two approaches are.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by ahf):

 My initial patch was more or less like that, except that I toggled the
 `ZLIB_METHOD` in the branch where the `Accept-Encoding` header value was
 read.

 I added the flag to the `parse_accept_encoding_header()` in case we wanted
 to do ".zstd", ".gz", and ".lzma" at some point in the future, which
 should make that more trivial to do. I'm OK with either solutions though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Let's go with the smaller one for now?  I think that, by using Accept-
 Encoding, we're moving to deprecate the use of .z and other extensions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by ahf):

 Works for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed in 8266d193a608

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-10 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by yawning):

 Replying to [comment:19 nickm]:
 > Fixed in 8266d193a608

 I'm not going to re-open this, but the behavior is still wrong in certain
 cases.

 Specifically, an error (or a double compressed payload) should be returned
 when the `.z` request contains an `Accept-Encoding` header that specifies
 anything other than `identity`/`deflate`.  This may be contrived and not
 worth worrying about, but the correct behavior (especially in the former
 case) isn't that hard.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified

2017-05-11 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:  ahf
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Added #22233 to track that and related discussion; probably missed
 something significant in my summary.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22206 [Core Tor/Tor]: Fetching compressed consensus gives it uncompressed if Accept-Encoding header is specified (was: Fetching compressed consensus behaves unpredictably strange)

2017-05-08 Thread Tor Bug Tracker & Wiki 
#22206: Fetching compressed consensus gives it uncompressed if Accept-Encoding
header is specified
--+
 Reporter:  Sebastian |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs