[tor-bugs] #22302 [Core Tor/Chutney]: test-network.sh uses a deprecated arithmetic syntax

[Tor Bug Tracker & Wiki]

#22302: test-network.sh uses a deprecated arithmetic syntax
--+--
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 `test-network.sh` uses a deprecated bash-specific syntax to do arithmetic.
 This fails on systems like Ubuntu and Debian that use dash instead of bash
 for `/bin/sh`.  `test-network.sh` should probably use the POSIX
 `$((arithmetic_expr))` syntax instead.

 Typical error from the log files:

 {{{
 /home/tlyu/src/tor/../chutney/tools/test-network.sh: 302: [: Illegal
 number: $[n_rounds+1]
 Completed $[n_rounds+1] of 1 verify rounds.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22302 [Core Tor/Chutney]: test-network.sh uses a deprecated arithmetic syntax

[Tor Bug Tracker & Wiki]

#22302: test-network.sh uses a deprecated arithmetic syntax
--+--
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by catalyst):

 Patch in https://gitlab.com/argonblue/chutney/merge_requests/1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22302 [Core Tor/Chutney]: test-network.sh uses a deprecated arithmetic syntax

[Tor Bug Tracker & Wiki]

#22302: test-network.sh uses a deprecated arithmetic syntax
--+--
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by catalyst):

 * status:  new => needs_review


Comment:

 oops, forgot to set needs_review

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22302 [Core Tor/Chutney]: test-network.sh uses a deprecated arithmetic syntax

[Tor Bug Tracker & Wiki]

#22302: test-network.sh uses a deprecated arithmetic syntax
--+-
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by teor):

 * status:  needs_review => merge_ready
 * milestone:  Tor: unspecified =>


Comment:

 The bash thing will continue to haunt me until I switch my default sh.

 This is the only instance of this pattern in chutney.

 {{{
 $ grep -r --exclude-dir .git --exclude-dir net --exclude '*~' '$[[]' .
 ./tools/test-network.sh:  n_rounds=$[n_rounds+1]
 }}}

 I think this is fine to merge, is there any reason it is WIP on gitlab?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22302 [Core Tor/Chutney]: test-network.sh uses a deprecated arithmetic syntax

[Tor Bug Tracker & Wiki]

#22302: test-network.sh uses a deprecated arithmetic syntax
--+-
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by catalyst):

 I labeled it WIP partly to prevent accidental click-merge and partly to
 indicate it needed review.  Feel free to ignore that, or I can delete the
 WIP notation if you want.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22302 [Core Tor/Chutney]: test-network.sh uses a deprecated arithmetic syntax

[Tor Bug Tracker & Wiki]

#22302: test-network.sh uses a deprecated arithmetic syntax
--+--
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Core Tor/Chutney  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Closed by merging 9e48988 into master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs