Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

2017-05-20 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  needs_revision
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by cypherpunks):

 * status:  needs_review => needs_revision


Comment:

 The patch fixes the issue on the search page but the results link to the
 incorrect details page. Please ignore the patch for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

2017-05-20 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+--
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  needs_review
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cypherpunks):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

2017-05-20 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+--
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 It seems using the fingerprint (instead of the lookup) parameter returns
 the responses that Atlas expects.

 
https://onionoo.torproject.org/details?fingerprint=30AFA68C0F9B30C213F19B6CE57F7D8CA4B77A25
 
https://onionoo.torproject.org/details?fingerprint=D752CBAB72003DE7774D032186A47ACE09CD27C1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

2017-05-20 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+--
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 This is caused by
 [https://gitweb.torproject.org/atlas.git/tree/js/models/relay.js#n136
 js/models/relay.js#n136] which processes only the first relay or bridge
 (with a preference for the relay in the case of both). In this case Atlas
 requests
 
[https://onionoo.torproject.org/summary?search=D752CBAB72003DE7774D032186A47ACE09CD27C1
 the summary document] which returns the relay and bridge. For both the
 detail document is requested which returns
 
[https://onionoo.torproject.org/details?lookup=30AFA68C0F9B30C213F19B6CE57F7D8CA4B77A25
 the relay] and
 
[https://onionoo.torproject.org/details?lookup=D752CBAB72003DE7774D032186A47ACE09CD27C1
 the bridge]. The response for the bridge contains both the relay and the
 bridge where Atlas takes preference for the relay details and ignores the
 bridge details leading to duplicate results.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

2017-05-19 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+--
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arma):

 Oh -- on the example atlas page, both entries are listed as 'relay'. That
 definitely sounds like a bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node.

2017-05-19 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+--
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arma):

 Seems like that might be a feature? Since there are the stats about it
 when it was a bridge, and the stats about it when it was a relay, and we
 would want onionoo to track each of them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22307 [Metrics]: Atlas shows duplicates shown when a bridge changes to a publicly listed node. (was: Atlas showz duplicates shown when a bridge changes to a publicly listed node.)

2017-05-19 Thread Tor Bug Tracker & Wiki 
#22307: Atlas shows duplicates shown when a bridge changes to a publicly listed
node.
--+--
 Reporter:  entry |  Owner:  metrics-team
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  atlas |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs