Re: [tor-bugs] #22328 [Applications/Tor Browser]: Check if we can remove OSX clang PIE wrappers

[Tor Bug Tracker & Wiki]

#22328: Check if we can remove OSX clang PIE wrappers
---+
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-gitian, TorBrowserTeam201706R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, nice. Applied to `master` and `maint-7.0` (commit
 e8618a272b8ce8c8de834314b31a2fdd9259513a and
 2b6992cf9aedafd4a121ff820aba182d0906c593).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22328 [Applications/Tor Browser]: Check if we can remove OSX clang PIE wrappers

[Tor Bug Tracker & Wiki]

#22328: Check if we can remove OSX clang PIE wrappers
---+---
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201706R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * keywords:  tbb-gitian => tbb-gitian, TorBrowserTeam201706R
 * status:  new => needs_review


Comment:

 I have been doing a nightly build with the following patch:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 bundle.git/commit/?h=bug_22328

 And the binaries produced are still PIE.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22328 [Applications/Tor Browser]: Check if we can remove OSX clang PIE wrappers

[Tor Bug Tracker & Wiki]

#22328: Check if we can remove OSX clang PIE wrappers
--+---
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-gitian|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by boklm):

 After removing the clang wrappers in rbm, and doing a test build, the
 binaries produced are still PIE. So it looks like the wrappers are no
 longer needed.

 I have now started a build in gitian with the same changes to confirm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22328 [Applications/Tor Browser]: Check if we can remove OSX clang PIE wrappers

[Tor Bug Tracker & Wiki]

#22328: Check if we can remove OSX clang PIE wrappers
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-gitian
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 In the fix for #20439, we added clang wrappers to add the `-fPIE` flag,
 and avoid a build error when the `-fPIE` flag is explicitly set in the
 FLAGS.

 After the switch to esr52, we should check if using those wrappers is
 still needed, or if they can be removed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs