Re: [tor-bugs] #22560 [Applications/Tor Browser]: Update privacy.thirdparty.isolate preference in Torbutton

[Tor Bug Tracker & Wiki]

#22560: Update privacy.thirdparty.isolate preference in Torbutton
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201706R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks for the reviews I followed both suggestions and pushed the
 resulting fix to `master` (commit
 b917b2024bb71b2be832439df793ae5ec91d8082).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22560 [Applications/Tor Browser]: Update privacy.thirdparty.isolate preference in Torbutton

[Tor Bug Tracker & Wiki]

#22560: Update privacy.thirdparty.isolate preference in Torbutton
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201706R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Looks good to me as well. I'd also suggest changing the var
 `block_thirdparty` to `firstparty_isolate` or something similar.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22560 [Applications/Tor Browser]: Update privacy.thirdparty.isolate preference in Torbutton

[Tor Bug Tracker & Wiki]

#22560: Update privacy.thirdparty.isolate preference in Torbutton
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201706R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 r=brade, r=mcs
 This looks good to us, although it would be good for Arthur to also review
 it.
 One small suggestion: rename the `torbutton_update_thirdparty_prefs()`
 function to `torbutton_update_isolation_prefs()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22560 [Applications/Tor Browser]: Update privacy.thirdparty.isolate preference in Torbutton

[Tor Bug Tracker & Wiki]

#22560: Update privacy.thirdparty.isolate preference in Torbutton
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201706R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-7.0-issues => tbb-7.0-issues, tbb-regression,
 TorBrowserTeam201706R
 * status:  new => needs_review


Comment:

 `bug_22560`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_22560=6d1f0d8f94fbd25df1673bd2f5387829dfda7c68)
 in my public Torbutton repository has a fix up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22560 [Applications/Tor Browser]: Update privacy.thirdparty.isolate preference in Torbutton

[Tor Bug Tracker & Wiki]

#22560: Update privacy.thirdparty.isolate preference in Torbutton
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-7.0-issues
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 `privacy.thirdparty.isolate` is gone with the switch to ESR52, yet we
 still try to use it in Torbutton. We should get rid of the preferences in
 `torbutton_update_thirdparty_prefs()` that we don't need anymore and adapt
 `privacy.thirdparty.isolate` for the remaining ones (it is
 `privacy.firstparty.isolate` now).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs