Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  review-group-18 technical-debt  |  Actual Points:  .3
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+--
Changes (by catalyst):

 * keywords:  review-group-18 => review-group-18 technical-debt


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-18  |  Actual Points:  .3
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:   => .3


Comment:

 Merged; thanks for reviewing!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-18  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Thanks! Looks good to me. Definitely a noteworthy achievement!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-18  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 new branch is callgraph_reduction_v2.  Better?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-18  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 Replying to [comment:4 catalyst]:
 > Looks mostly good.

 Thanks for the review!

 >  A few nits: callgraph reduction numbers don't match between commit
 message and this ticket; also it fails check-spaces.

 Will fix; the numbers have fluctuated between when I originally wrote the
 patch and now.  Right now the reduction is 58 -> 28.

 > If it's a factor-of-three reduction in the largest SCC then maybe it
 should get a changes file, too?

 Will fix that too. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-18  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Looks mostly good.  A few nits: callgraph reduction numbers don't match
 between commit message and this ticket; also it fails check-spaces.  If
 it's a factor-of-three reduction in the largest SCC then maybe it should
 get a changes file, too?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()

[Tor Bug Tracker & Wiki]

#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
--+
 Reporter:  nickm |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:  .2|   Reviewer:
  Sponsor:|
--+
 I have a patch in branch "callgraph_reduction" that takes the size of our
 largest SCC from down to 26 functions (from ~64).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs