[tor-bugs] #22635 [Internal Services/Service - jenkins]: Run tor's make test-stem in Jenkins

[Tor Bug Tracker & Wiki]

#22635: Run tor's make test-stem in Jenkins
-+
 Reporter:  catalyst |  Owner:  weasel
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - jenkins  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 Currently, our Jenkins CI runs stem's self-tests, but doesn't ensure that
 `make test-stem` works from the tor source tree.  In the past `make test-
 stem` has failed for reasons described in #22301.  We should run `make
 test-stem` in our CI so it can be reliable enough for developers to run
 regularly and know that its results are meaningful.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22635 [Internal Services/Service - jenkins]: Run tor's make test-stem in Jenkins

[Tor Bug Tracker & Wiki]

#22635: Run tor's make test-stem in Jenkins
-+
 Reporter:  catalyst |  Owner:  weasel
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - jenkins  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by atagar):

 Hi catalyst, not sure I follow. Tor's 'test-stem' target should simply be
 an alias for stem's 'run_tests.py --all --target RUN_ALL' which is
 presently run in jenkins for every tor or stem push...

 https://jenkins.torproject.org/job/stem-tor-ci/

 Issues you ran into were with peculiarities of your environment. Fine
 things to fix certainly, but they wouldn't have been caught by jenkins.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22635 [Internal Services/Service - jenkins]: Run tor's make test-stem in Jenkins

[Tor Bug Tracker & Wiki]

#22635: Run tor's make test-stem in Jenkins
-+
 Reporter:  catalyst |  Owner:  weasel
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - jenkins  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by catalyst):

 I think you're right that there are environmental dependencies for those
 issues, but I think they're not uncommon ones.  I think to make this
 reproduce the observed failures, we would have to make sure there isn't a
 system tor binary installed in the Jenkins environment that runs this
 test.

 As I recall, the issues in #22301 depended on both the lack of a tor
 binary in the default PATH and running `make test-stem` in the tor source
 tree (instead of running `run_tests.py` in the stem source tree).  This is
 not an unusual combination, especially for a (possibly new) developer who
 has no reason to install a system tor.  (Note at least 3 developers
 independently experienced those bugs while attempting to follow the
 guidelines in `CodingStandards.md`.)

 Now that I think about it more, it's also useful to make sure that the
 stem tests don't unintentionally run the system tor (thereby producing
 invalid or misleading results).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22635 [Internal Services/Service - jenkins]: Run tor's make test-stem in Jenkins

[Tor Bug Tracker & Wiki]

#22635: Run tor's make test-stem in Jenkins
-+
 Reporter:  catalyst |  Owner:  weasel
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - jenkins  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by atagar):

 Gotcha. Actually, I do like the idea of adding test coverage for this but
 I suspect Jenkins isn't the right way to go. Maybe we should wrap stem's
 run_tests.py with a shell script invoking 'env -i' to avoid any accidental
 dependencies on environment variables?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs