Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+

Comment (by arma):

 Fyi, this fix got broken in 0.3.3.1-alpha because we split
 options->DataDirectory into options->DataDirectory_option: #28298.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 Much better!

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  needs_information => needs_review


Comment:

 Whoops. Try ticket22731 q?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by dgoulet):

 Replying to [comment:6 nickm]:
 > See branch `bug22731` in my public repository for a simple
 implementation here.  It turns out that the warn_about_relative_paths()
 function already did most of what we want.

 I see no such branch in `nickm/bug22731` :S ...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
-+
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-23  |  Actual Points:  .1
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_review => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm
 * actualpoints:   => .1


Comment:

 See branch `bug22731` in my public repository for a simple implementation
 here.  It turns out that the warn_about_relative_paths() function already
 did most of what we want.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 (Once this is done, we can probably close #22101 and #22102, unless they
 turn out to be more complicated than we had thought.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 Replying to [comment:1 arma]:
 > I think the fix is that we should refuse to start when DataDirectory is
 relative and RunAsDaemon is set.
 >
 > It basically doesn't work at this point, so I don't think we'd be
 ruining anybody's day.
 >
 > And it would simplify a bunch of the logic that has confused us in
 related bugs (#22101, #20456).

 I agree.  This is probably the simplest way to solve this set of problems.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by mcs):

 Some info about Tor Launcher:
 * It always uses absolute paths for the config directives that it
 generates in code, e.g., for `DataDirectory`.
 * Relative paths are used in a torrc-defaults file for some static
 configuration, e.g.
  `ClientTransportPlugin obfs2,obfs3,obfs4,scramblesuit exec
 PluggableTransports/obfs4proxy`
 * Tor Launcher does not enable `RunAsDaemon`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by mcs):

 * cc: mcs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 I think the fix is that we should refuse to start when DataDirectory is
 relative and RunAsDaemon is set.

 It basically doesn't work at this point, so I don't think we'd be ruining
 anybody's day.

 And it would simplify a bunch of the logic that has confused us in related
 bugs (#22101, #20456).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22731 [Core Tor/Tor]: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of its datadirectory files

[Tor Bug Tracker & Wiki]

#22731: Relative DataDirectory + RunAsDaemon = Tor can't read or write most of 
its
datadirectory files
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Bug #22101 shows a case where if you start your Tor with a relative (non
 absolute) DataDirectory, and {{{RunAsDaemon 1}}}, and
 {{{CookieAuthentication 1}}} but no {{{CookieAuthFile}}}, then Tor will
 attempt to save your control_auth_cookie file to
 $datadir/$datadir/control_auth_cookie. (Yes, you read that correctly,
 $datadir/$datadir/.) The attempt will fail because Tor doesn't mkdir the
 $datadir/$datadir directory.

 If you start with a relative DataDirectory, and RunAsDaemon, but no
 CookieAuthentication, then your Tor will start, but it will attempt to
 (and fail to) write each of your datadirectory files -- state, cached-
 microdescriptors, etc, because it is trying to write them to
 $datadir/$datadir. I think that might be what teor saw in #20456, but he
 doesn't give us an actual torrc so I can't be sure.

 The bug is because we call get_datadir_fname(), which creates a filename
 that prepends $datadir, after we do the chdir($datadir) operation that
 comes with RunAsDaemon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs