Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-11-13 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.2.9.x-final


Comment:

 Backported to 0.2.9 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-27 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 The branch to backport is `bug22895_027`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-27 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.1.x-final


Comment:

 In that case, I think it's fine to take this in 0.3.2, and consider for a
 possible backport. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-27 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Thanks for the help Nick. I managed to compile Tor in 32-bit mode:

 {{{
 $ file src/or/tor
 src/or/tor: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV),
 dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 2.6.32,
 BuildID[sha1]=72f975f78f2ef98852368ebbe3a6205ddf0ea944, not stripped
 }}}

 I still have not managed to trigger this error unfortunately, even tho I
 compiled tor with `$ CFLAGS="-m32" ./configure --enable-gcc-warnings
 --disable-asciidoc --enable-expensive-hardening` and I checked that
 `src/ext/ed25519/donna/libed25519_donna.a` was built...

 Not sure what to do here. Anyone has tips on how to repro this?

 Otherwise, I just say we merge the patch since it just removes unused
 variables anyway (I checked all of them).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-25 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 Right; you're going to need 32-bit versions of the libraries you're using
 so that you can link against them. If you're on a linux distribution, most
 of them already have their libraries available in both 64-bit and 32-bit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-20 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by asn):

 Branch looks good to me. The variables removed are indeed unused.

 However, I wanted to compile the patch to check that it indeed fixes the
 gcc warnings. Can anyone help me compile tor in 32-bit mode? IIUC I should
 be doing `./configure --host=i686-linux-gnu "CFLAGS=-m32" && make`, but
 when I did that the configure script was complaining that it can't find my
 libevent. Is that the correct way to do it, and I just need to get a
 32-bit libevent or something? If someone helps me do this, I promise I'm
 gonna transcribe the process to `doc/HACKING/` for future generations to
 be able to do it as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-19 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport, 028-backport,  |  Actual Points:
  029-backport, 030-backport, 031-backport,  |
  compile, warning, 32bit, ed25519, review-  |
  group-21   |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-12 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.2-alpha
 Severity:  Normal   | Resolution:
 Keywords:  027-backport 028-backport|  Actual Points:
  029-backport 030-backport 031-backport |
  compile warning 32bit ed25519  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:   =>
 027-backport 028-backport 029-backport 030-backport 031-backport
 compile warning 32bit ed25519
 * milestone:   => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-12 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
--+
 Reporter:  cypherpunks   |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.7.2-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by cypherpunks):

 * status:  new => needs_review
 * version:   => Tor: 0.2.7.2-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-12 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
--+-
 Reporter:  cypherpunks   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by cypherpunks):

 I probably should provide a little more information. The unused variables
 are in the Curve25519 SSE2 header.

 {{{
 In file included from src/ext/ed25519/donna/ed25519-donna.h:55:0,
  from src/ext/ed25519/donna/ed25519_tor.c:38:
 src/ext/ed25519/donna/curve25519-donna-sse2.h:51:27: error:
 ‘packed121666121665’ defined but not used [-Werror=unused-const-variable=]
  static const packedelem64 packed121666121665 = {{121666, 121665}};
^~
 src/ext/ed25519/donna/curve25519-donna-sse2.h:48:27: error: ‘packed9638’
 defined but not used [-Werror=unused-const-variable=]
  static const packedelem64 packed9638 = {{19*4,19*2}};
^~
 src/ext/ed25519/donna/curve25519-donna-sse2.h:45:27: error:
 ‘packednineteenone’ defined but not used [-Werror=unused-const-variable=]
  static const packedelem64 packednineteenone = {{19, 1}};
^
 src/ext/ed25519/donna/curve25519-donna-sse2.h:39:27: error:
 ‘packedmask2625’ defined but not used [-Werror=unused-const-variable=]
  static const packedelem32 packedmask2625 = {{0x3ff,0,0x1ff,0}};
^~
 src/ext/ed25519/donna/curve25519-donna-sse2.h:32:27: error: ‘top32bitmask’
 defined but not used [-Werror=unused-const-variable=]
  static const packedelem32 top32bitmask = {{0x, 0x,
 0x, 0x}};
^~~~
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

2017-07-12 Thread Tor Bug Tracker & Wiki 
#22895: Unused variables in donna's SSE2 header
--+-
 Reporter:  cypherpunks   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 FWICT this only occurs on 32-bit x86 systems because of the
 [https://gitweb.torproject.org/tor.git/tree/src/ext/ed25519/donna/ed25519
 -donna-portable.h?id=3aba8490ba590899b6c23071ef0b4269d8c36d37#n147
 portability header].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs