Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by atagar):

 * status:  needs_information => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+---
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by atagar):

 Interesting. Thanks catalyst, pushed a tweak. Mind giving this a try?

 https://gitweb.torproject.org/stem.git/commit/?id=d378100

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+---
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by catalyst):

 Thanks.  I think I haven't seen a deadlock since updating to that.

 Here's one failure (after I had been running `run_tests.py` in a loop for
 a while:

 {{{
 ==
 test.integ.process.TestProcess
 ==

 test_can_run_multithreaded 0 ms  [SUCCESS]
 test_dump_config_argument  0 ms  [SUCCESS]
 test_hash_password 0 ms  [SUCCESS]
 test_hash_password_requires_argument   0 ms  [SUCCESS]
 test_help_argument 0 ms  [SUCCESS]
 test_hush_argument 0 ms  [SUCCESS]
 test_launch_tor_with_config_via_file   0 ms  [SUCCESS]
 test_launch_tor_with_config_via_stdin  0 ms  [SUCCESS]
 test_launch_tor_with_timeout   0 ms  [SUCCESS]
 test_list_fingerprint_argument 0 ms  [SUCCESS]
 test_list_torrc_options_argument   0 ms  [SUCCESS]
 test_no_orphaned_process   0 ms  [SUCCESS]
 test_quiet_argument0 ms  [SUCCESS]
 test_take_ownership_via_controller   [FAILURE]
 test_take_ownership_via_pid0 ms  [SUCCESS]
 test_torrc_arguments   0 ms  [SUCCESS]
 test_torrc_arguments_via_stdin 0 ms  [SUCCESS]
 test_unanonymous_hidden_service_config_must_match  0 ms  [SUCCESS]
 test_validate_config_argument  0 ms  [SUCCESS]
 test_version_argument  0 ms  [SUCCESS]
 test_with_invalid_config   0 ms  [SUCCESS]
 test_with_missing_torrc0 ms  [SUCCESS]

 ==
 FAIL: test_take_ownership_via_controller
 --
 Traceback (most recent call last):
   File "/home/tlyu/src/stem/stem/util/test_tools.py", line 150, in
 
 self.method = lambda test: self.result(test)  # method that can be
 mixed into TestCases
   File "/home/tlyu/src/stem/stem/util/test_tools.py", line 214, in result
 test.fail(self._result.msg)
 AssertionError: Traceback (most recent call last):
   File "/home/tlyu/src/stem/stem/util/test_tools.py", line 165, in
 _wrapper
 runner(*args) if args else runner()
   File "/home/tlyu/src/stem/test/integ/process.py", line 625, in
 test_take_ownership_via_controller
 take_ownership = True,
   File "/home/tlyu/src/stem/stem/process.py", line 274, in
 launch_tor_with_config
 return launch_tor(tor_cmd, ['-f', '-'], None, completion_percent,
 init_msg_handler, timeout, take_ownership, stdin = config_str)
   File "/home/tlyu/src/stem/stem/process.py", line 153, in launch_tor
 raise OSError('Process terminated: %s' % last_problem)
 OSError: Process terminated: Failed to bind one of the listener ports.


 --
 Ran 22 tests in 0.001s

 FAILED (failures=1)


 Shutting down tor... done

 Style checks require pycodestyle version 1.4.2 or later. Please install it
 from...
   http://pypi.python.org/pypi/pycodestyle

 TESTING FAILED (35 seconds)
   [RUN_NONE] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_OPEN] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_PASSWORD] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_COOKIE] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_MULTIPLE] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_SOCKET] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_SCOOKIE] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL
   [RUN_PTRACE] test_take_ownership_via_controller
 (test.integ.process.TestProcess) ... FAIL

 You can re-run just these tests with:

   ./run_tests.py --tor ../tor/src/or/tor --all --log notice --target
 RUN_ALL -v --test test.integ.process
 }}}

 and another one:

 {{{

Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+---
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by atagar):

 * status:  new => needs_information


Comment:

 Fix pushed, you should no longer see deadlocks:
 https://gitweb.torproject.org/stem.git/commit/?id=7901ff1

 Ball's back in your court. What's the process test failing with?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by atagar):

 Hi catalyst, think I know why you're getting a deadlock. Seems unexpected
 exceptions cause aynchronously run tests to never join. Fixing that. That
 said, there's likely a stacktrace somewhere earlier in your testing output
 and we need to sort out that too (what I'm working on now will simply turn
 the deadlock into a failing test).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+
 Oddly enough it seems to happen less often with `-v`.

 Excerpt from one of the hangs when using `-v`:

 {{{
 ==
test.integ.installation.TestInstallation
 ==

 test_install   0 ms  [SUCCESS]
 test_sdist   627 ms  [SUCCESS]

 --
 Ran 2 tests in 0.628s

 OK

 ==
 test.integ.process.TestProcess
 ==
 }}}

 During the hang I see the following tor and python processes:
 {{{
 tlyu  96853  1.4  9.0 21474964912 365204 pts/0 S+ 15:39   0:01
 /home/tlyu/src/stem/../tor/src/or/tor -f
 /home/tlyu/src/stem/test/data/torrc __OwningControllerProcess 96673
 tlyu  96673  4.4  1.0 394728 41408 pts/0S+   15:39   0:05 python
 ./run_tests.py --tor ../tor/src/or/tor --all --log notice --target RUN_AL
 -v
 tlyu  96680  1.2  0.0  0 0 pts/0ZN+  15:39   0:01 [python]
 
 tlyu  96686  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96687  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96689  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96690  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96692  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96693  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96701  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 tlyu  96702  0.0  0.0  0 0 pts/0ZN+  15:39   0:00 [python]
 
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs