[tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
--+-
 Reporter:  isis  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust, tor-build
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:  SponsorZ  |
--+-
 In #22905, I discussed a problem that is partially the result of
 committing `src/rust/Cargo.lock`.

 > [Including `Cargo.lock` files] is possibly a good idea, because we're
 specifying the hash we expect. It might be a bad idea, because it
 specifies the registry for packages, which I'm pretty sure will mean
 "offline" builds would never work. In addition, it also conflicts with the
 dependency specification in `src/rust/tor_util/Cargo.toml` […]

 That is, I'm pretty sure that no matter what we do on #22830, "offline"
 builds are going to be broken because of including this lockfile.  We
 should figure out what the benefits of having it are, and if we can live
 without them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--

Comment (by isis):

 See also http://doc.crates.io/faq.html#why-do-binaries-have-cargolock-in-
 version-control-but-not-libraries which also mentions the dependency
 problem in #22905.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--

Comment (by alexcrichton):

 Oh I think my comment on #22905 may actually be more relevant for this
 issue! I'm not 100% familiar with the layout of projects here, but the
 response to that comment may help guide this issue!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--

Comment (by Sebastian):

 Same for my comment, maybe this is a duplicate we should close?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by dgoulet):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by chelseakomlo):

 * cc: chelseakomlo (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by manish.earth):

 * cc: manishearth@… (added)


Comment:

 The recommendation is to commit them for binaries and not libraries, but
 the actual recommendation is closer to "commit them for things which won't
 be used as dependencies of other rust crates". Which is true for binaries,
 but also for static libraries that you link to from C. So for the
 staticlib you compile you probably want to check in the lockfile.

 (You'll need to check in a lockfile if you intend to cargo vendor crates
 anyway)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--

Comment (by chelseakomlo):

 Closing as this appears to be resolved- feel free to re-open if there are
 other pending questions. Agree with committing a lockfile for the tor
 binary.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by chelseakomlo):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs