Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+--
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+--
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This looks good to me. I merged it to master with commit
 `5e72f5077d7c974e30c9f48f2c554ded6e8358d1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  ff60-esr, TorBrowserTeam201806 => ff60-esr,
 TorBrowserTeam201806R


Comment:

 `bug_23231` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_23231=aa79addec263ad31bad46f589e5964173b07d24f)
 removes out workaround as it got solved upstream.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  #26203  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by gk):

 * cc: sukhe (added)
 * parent:   => #26203


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201804, ff60-esr  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by gk):

 * keywords:  TorBrowserTeam201804, ff60-esr-will-have =>
 TorBrowserTeam201804, ff60-esr


Comment:

 Actually, we need to have at least a patch to remove the workaround in
 `tor-browser-build`, so let's move that again on our radar for ESR60.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201804, ff60-esr-  |  Actual Points:
  will-have  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by cypherpunks):

 Replying to [comment:25 gk]:
 > Replying to [comment:24 cypherpunks]:
 > > Replying to [comment:21 gk]:
 > > > Interestingly, I recall that I still needed that when I worked on
 the Stylo bug, which means with a pretty recent m-c tree.
 > > (As you're not polite and don't think it's good form to reply to
 useful comments, this comment was reduced.)
 > > https://bugzilla.mozilla.org/show_bug.cgi?id=1257501
 >
 > The bug you want is https://bugzilla.mozilla.org/show_bug.cgi?id=1443823
 (see my comment 8).
 Who wants?
 > The patch in the bug you are linking to is just concerned with the 32bit
 cross-compilation, which is not the problem we are facing in this ticket:
 only when cross-compiling for 64bit Windows are we hitting the STL wrapper
 related compiler error.
 Forbid the usage of `-fno-keep-inline-dllexport` optimization option
 entirely and recheck.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201804, ff60-esr-  |  Actual Points:
  will-have  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:24 cypherpunks]:
 > Replying to [comment:21 gk]:
 > > Interestingly, I recall that I still needed that when I worked on the
 Stylo bug, which means with a pretty recent m-c tree.
 > (As you're not polite and don't think it's good form to reply to useful
 comments, this comment was reduced.)
 > https://bugzilla.mozilla.org/show_bug.cgi?id=1257501

 The bug you want is https://bugzilla.mozilla.org/show_bug.cgi?id=1443823
 (see my comment 8). The patch in the bug you are linking to is just
 concerned with the 32bit cross-compilation, which is not the problem we
 are facing in this ticket: only when cross-compiling for 64bit Windows are
 we hitting the STL wrapper related compiler error.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201804, ff60-esr-  |  Actual Points:
  will-have  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by cypherpunks):

 Replying to [comment:21 gk]:
 > Interestingly, I recall that I still needed that when I worked on the
 Stylo bug, which means with a pretty recent m-c tree.
 (As you're not polite and don't think it's good form to reply to useful
 comments, this comment was reduced.)
 https://bugzilla.mozilla.org/show_bug.cgi?id=1257501

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201804, ff60-esr-  |  Actual Points:
  will-have  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by tom):

 Sorry, no insight. I kept the tab open expecting to eventually need this
 but never did.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201804, ff60-esr-  |  Actual Points:
  will-have  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201804 => TorBrowserTeam201804, ff60-esr-will-
   have


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201804  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by gk):

 * cc: tom (added)


Comment:

 Note, that Tom does not seem to have a problem with this issue while
 building for 64bit. I am not sure why that's the case but we should figure
 it out and close https://bugzilla.mozilla.org/show_bug.cgi?id=1392604 once
 we know what's up. Marking this tentatively as `ff60-esr-will-have`.

 Interestingly, I recall that I still needed that when I worked on the
 Stylo bug, which means with a pretty recent m-c tree. Adding Tom as he
 might have some insight in this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201712  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by gk):

 * status:  needs_review => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201711  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by gk):

 * keywords:  TorBrowserTeam201711R => TorBrowserTeam201711
 * parent:  #23229 =>


Comment:

 Okay, I took the patch file road and added a respective commit in `tor-
 browser-build` (commit b66d7da8eb4989593792381a8f3ac40c1ad38fde) on
 `master`. That should be enough as a workaround for now. Leaving this
 ticket open for a proper fix, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201711R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201711 => TorBrowserTeam201711R


Comment:

 I attached a patch reverting the change from bug 1269251. I think we could
 take this patch in our git branch as a workaround until
 https://bugzilla.mozilla.org/show_bug.cgi?id=1392604 is fixed. Or we could
 store it as a patch file in `tor-browser-build/projects/firefox` if we
 want to apply it only to the Windows 64 build as it is not necessary for
 the 32bit one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201711  |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by boklm):

 * Attachment "0001-Bug-23231-disable-STL-Wrappers-on-Windows.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201709  |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--

Comment (by cypherpunks):

 There are too much issues, so just random thoughts:
 First of all, https://dxr.mozilla.org/mozilla-esr52/source/config/gcc-stl-
 wrapper.template.h should be updated with all the fixes as msvc- one.
 Do we need https://hg.mozilla.org/mozilla-central/rev/491c4ae1ea4a?
 But, generally, read https://bugzilla.mozilla.org/show_bug.cgi?id=427107 -
 they almost don't test paths without jemalloc :(
 Also, there is
 {{{
 // MinGW doesn't appropriately inline these functions in debug builds,
 // so we need to do some extra coercion for it to do so. Bug 1332747
 }}}
 instead of reading
 https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Inline.html (it's short)
 There is an assumption that they didn't take into consideration mingw-w64
 when they did https://bugzilla.mozilla.org/show_bug.cgi?id=868814.
 But this error is about visibility (MOZ_EXPORT) and not inlining (but
 `-fno-keep-inline-dllexport` may affect this).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201709  |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--

Comment (by boklm):

 I tried a build with this, however it didn't fix the build issue:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_23231_v2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201709  |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by gk):

 * keywords:   => TorBrowserTeam201709


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:  Sponsor4
--+--
Changes (by gk):

 * sponsor:   => Sponsor4


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 This is https://bugzilla.mozilla.org/show_bug.cgi?id=1392604. boklm: Could
 you test whether a fix along the idea glandium had is working for us?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows (was: Error in STL wrappers when building firefox for Windows 64)

[Tor Bug Tracker & Wiki]

#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cypherpunks):

 * type:  task => defect


Comment:

 > for Windows 64
 "Windows 10 is the last version of Windows" (c) M$ ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs