Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  merge_ready
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM dgoulet!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by dgoulet):

 I've fixed an issue that appeared with #23502 which is that an intro point
 can have an IPv6 only. Then also make happy check-spaces.

 See my branch `ticket23310_032_02`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 OK, removed unittest (d) from above based on dgoulet's suggestion and also
 rebased on latest master. Putting it back on needs_review so that dgoulet
 can inspect.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Ooook so #23502 has almost the equivalency of
 `extend_info_from_lspecs` in that branch, I didn't realized that I had
 made a test previously in this branch.

 So I suggest we remove that test from the branch. Furthermore, maybe can
 you rebase it on latest master?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by asn):

 * status:  merge_ready => needs_review


Comment:

 Putting it on needs_review for some dgoulet validation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  merge_ready
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by asn):

 * status:  new => merge_ready


Comment:

 Setting this to `merge_ready` I will soon compute new test coverage
 metrics for master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by asn):

 OK I think we now have enough unittests collected here that warrants its
 own patch and merge time.

 Please check branch `bug23310` in my repo for a branch based on latest
 master, that encorporates all the above branches together:
 a) An expansion pack for `test_client_service_hsdir_set_sync()`.
 b) A unittest for HSDir index computation including a python test vector.
 c) A unittest for clients picking intro points, plus a memleak fix
 (75d85d6078).
 d) A unittest for turning link specifier sets to `extend_info_t`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by asn):

 Pushed some improvements to the #23387 tests in my `bug23310_hsdir_sync`
 branch.
 Let's include those too when we make the final branch here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by dgoulet):

 More tests, including those in asn's branch above, can be found here:
 `ticket23310_032_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
+--
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Very High   |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, test-unit  |  Actual Points:
Parent ID:  #23300  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by asn):

 Pushed branch `bug23310_client_intro_test` in my repo which tests the
 client-side picking intro points, the intro state cache, etc.

 It also found a subtle memleak which is fixed as part of the branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23310 [Core Tor/Tor]: test: prop224 client unit tests

[Tor Bug Tracker & Wiki]

#23310: test: prop224 client unit tests
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-hs, prop224, test-unit
Actual Points:|  Parent ID:  #23300
   Points:|   Reviewer:
  Sponsor:|
--+
 We need to a LOT more client unit tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs