Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


Comment:

 (As an aside, we didn't catch this with chutney, because the first
 scheduled download in chutney was 30s, and chutney waits 60s. Now the
 chutney schedules are consistent with each other, too.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * owner:  (none) => teor
 * status:  needs_review => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by teor):

 I pushed a fixup to this branch to fix a bug that arma identified on IRC:
 bridges reset their download schedule when they're successfully
 downloaded, and then want to do the next download after an hour. (Maybe
 the way I fixed it isn't the best design, but it does maintain the
 pre-#17750 behaviour.)

 I also added a commit that refactors bridge downloads to use the
 "increment on attempt" functions. (They were using the "increment on
 failure" functions to increment on each attempt, and never incrementing on
 failure, which was confusing.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by isis):

 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+

Comment (by isis):

 * `435952538` LGTM
 * `61227b7b0` LGTM
 * `ea662f00d` LGTM
 * `836cc60d4` LGTM

 FWIW, [https://travis-ci.org/isislovecruft/tor/builds/269821789 clang
 builds are broken], but that's not your fault, it appears to be from
 commit `6eb9de1b8c` where there's now two `typedef struct
 response_handler_args_t`s in `src/or/directory.h`. I made #23358 for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 Forgot to change state after review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  merge_ready
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+

Comment (by nickm):

 I'm wondering whether we shouldn't extract the magic pair of calls to
 download_status_implement() and turn them into some other "adjust bridge
 download schedule" function?  Or use two separate schedules?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_revision
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 Replying to [comment:13 nickm]:
 > I'm wondering whether we shouldn't extract the magic pair of calls to
 download_status_implement() and turn them into some other "adjust bridge
 download schedule" function?  Or use two separate schedules?

 I think we should use two separate schedules, like we do for bootstrapping
 consensuses and regular consensuses. This makes the different behavior
 explicit, rather than relying on magic numbers.

 It also allows us to have more fine-grained control over how often we
 retry missing bridge descriptors.

 We could use schedules that match the old behaviour:
 {{{
 TestingMissingBridgeDownloadSchedule 0, 1200, 900, 900, 3600
 TestingBridgeDownloadSchedule 1200, 900, 900, 3600
 /* And in a test network */
 TestingMissingBridgeDownloadSchedule 0, 60, 30, 30, 60
 TestingBridgeDownloadSchedule 60, 30, 30, 60
 }}}

 But we probably want something more like this:
 {{{
 /* If we can't get a bridge descriptor, backoff exponentially, just like
 authority consensus downloads */
 TestingMissingBridgeDownloadSchedule 0, 3, 7, 3600, 10800, 25200, 54000,
 111600, 262800
 /* If the bridge keeps giving us a valid descriptor, it's ok to keep
 asking for one every 6 hours (this gives a bridge client 4 attempts per
 day to refresh each bridge descriptor) */
 TestingBridgeDownloadSchedule 21600, 21600
 /* And in a test network, match authority consensus downloads */
 TestingMissingBridgeDownloadSchedule 0, 0, 5, 10, 15, 20, 30, 60
 TestingBridgeDownloadSchedule 30, 30
 }}}

 Is there any reason that a bridge client with a valid bridge descriptor
 should re-download it every hour?

 I'm happy to make this change, but it will probably be towards the end of
 the week. Feel free to grab this ticket if you want to do it before then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 I updated the branch with a new design that:
 * runs quick checks when we don't know any bridge descriptors
 * when we get a (new/uncached) bridge descriptor, don't check that
 descriptor again for a few hours

 This splits the standard bridge schedule into a Bridge and a
 BridgeBootstrap schedule.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  1
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by teor):

 * actualpoints:  0.5 => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  1
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Nice!  This looks much cleaner this way.  I'm testing and merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:  reopened
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  1
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by nickm):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I ran into a crash bug here: if you have Bridge lines in your
 configuration, but UseBridges is 0, then the download_status_reset() in
 1b5e34badb06bb1a844a6e70164fc5c894d95d0a will fail.  I'm going to comment
 it out for now so that my Tor works.  I commented it out in
 63af663b8c83d771ed8fd29802e9a4c5cb074c70

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  1
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by teor):

 * status:  reopened => needs_review


Comment:

 Ok, so there are a few issues here:
 * the reset is too early: it should only happen when we actually go to use
 bridges
 * there's no way to check if a bridge download status has already been
 reset

 So it's ok to rely on the existing code to do this.

 I added comments explaining this in bug23347-extra.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  1
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+

Comment (by teor):

 I added #23524 and #23525 to clean up some related issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  teor
 Type:  defect| Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  1
Parent ID:| Points:  0.5
 Reviewer:  isis  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I've merged the patches for the child tickets, so I'm closing this one
 too.  Thanks for the fast response!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23347 [Core Tor/Tor]: Using bridges is not working anymore with tor on master (was: Switching from direct connection to a pluggable transport is not working anymore with tor on master)

[Tor Bug Tracker & Wiki]

#23347: Using bridges is not working anymore with tor on master
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bootstrap, tor-bridge-client  |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * priority:  Medium => Very High
 * actualpoints:   => 0.5


Comment:

 Please see my branch bug23347 on https://github.com/teor2345

 It fixes this issue, makes bridge bootstraps more reliable by trying each
 bridge 3 times (rather than once), and brings the man page up to date with
 the latest schedules.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs