Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  implemented
  tor-bootstrap, 034-triage-20180328, fast-fix   |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 You suggested, wrt `getinfo_helper_config()`:
 > we might want to change this to something that does NOT say "comma list"

 So, these values still accept the same format as before (ignoring
 everything except the first entry), and they still emit a subset of the
 format that they emitted before.

 On the other hand, they are closer to TimeInterval now than they were
 before.  So I'l change them to that.  Done in commit
 b205061eb13abd68a5335f8008c5121ef230c34e.

 Also, merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 One single comment on the PR.

 The rest lgtm so feel free to fix or no fix the comment on the PR and
 merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 >There is an extra commit c9c26d0 at the start of this branch.

 Okay; I've rebased the branch to remove this commit.

 >I think it was 0.2.9. Do we want to say 0.2.9 in the changes file?

 Makes sense; doing that too.

 I've re-pushed the branch: there are no other changes.

 >The rest seems sensible to me, but I would like someone else to review
 this too.

 Okay -- into needs_review it goes!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by teor):

 There is an extra commit c9c26d0 at the start of this branch.

 I wonder if it is ok that our coverage dropped slightly.
 But I think that's ok, because we removed 50 lines of code.

 When did we stop using deterministic schedules?
 I think it was 0.2.9. Do we want to say 0.2.9 in the changes file?

 The rest seems sensible to me, but I would like someone else to review
 this too.

 I opened #25844 for the relevant chutney changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 As requested, this is done in `ticket23354`.  Pull request at
 https://github.com/torproject/tor/pull/54

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap, 034-triage-20180328, fast-fix   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * keywords:
 refactor, s8-perf, technical-debt, tor-bootstrap, 034-triage-20180328,
 034-removed-20180328
 =>
 refactor, s8-perf, technical-debt, tor-bootstrap, 034-triage-20180328,
 fast-fix
 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by teor):

 Here's how we can remove these configs:
 * turn each download schedule config option into a single non-negative
 integer
 * set the default config value to the first item in each list
 * most schedules will be 0, so merge those schedules together, removing
 conditional code
 * maybe rename *DownloadSchedule to *DownloadInitialDelay

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 Whoops; look  like we had another duplicate as #23814.  But let's keep
 this ticket around for just removing the configs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  refactor, s8-perf, technical-debt,   |  Actual Points:
  tor-bootstrap  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by catalyst):

 * cc: catalyst (added)
 * keywords:  tor-bootstrap => refactor, s8-perf, technical-debt, tor-
 bootstrap
 * sponsor:   => Sponsor8
 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.3.x-final


Comment:

 #24151 is a duplicate; copied text from that ticket is:

 >It looks like the only code that uses DL_SCHED_DETERMINISTIC is testing
 code. We should rip out all code related to it. This will make it easier
 to refactor in the future and reduce the binary size by eliminating dead
 code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bootstrap  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23354 [Core Tor/Tor]: Remove deterministic download schedule code and configs (was: Remove redundant items from download schedules)

[Tor Bug Tracker & Wiki]

#23354: Remove deterministic download schedule code and configs
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bootstrap  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Description changed by teor:

Old description:

> Under exponential backoff, download schedules contain the maximum time we
> will wait, even if the random amount is larger.
>
> But in most cases, the random amount is much smaller than the maximum, so
> we could replace the item with the actual maximum, or delete it from the
> schedule altogether. (On the public network, the maximum is 4x the last
> entry, on test networks, it's 3x.)
>
> We should make these changes based on the schedules in #23347.

New description:

 Under exponential backoff, download schedules contain the ~~maximum time
 we will wait, even if the random amount is larger.~~ initial time we will
 wait, and everything else is random exponential from that point onwards.

 ~~But in most cases, the random amount is much smaller than the maximum,
 so we could replace the item with the actual maximum, or delete it from
 the schedule altogether. (On the public network, the maximum is 4x the
 last entry, on test networks, it's 3x.)~~

 So once we're sure that we will never revert to deterministic schedules,
 we should make each schedule into a single initial value, and remove the
 deterministic code.

 We should make these changes based on the schedules in #23347.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs