Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  closed
 Priority:  High  |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
  |  implemented
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:  #23300| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 confirmed with asn, and merging

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:
  |  merge_ready
 Priority:  High  |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:  #23300| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by dgoulet):

 * status:  accepted => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  accepted
 Priority:  High  |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop224, tor-hs, review-group-23  |  Actual Points:
Parent ID:  #23300| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * status:  merge_ready => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
-+
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  enhancement  | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:  #23300   | Points:
 Reviewer:  asn  |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 These maps are caches initialized by `hs_cache_init()` which is called by
 `hs_init()` in `tor_init()`.

 If they are NULL, tor is in a really really bad shape. I think there are
 some levels of confidence we can accept here that is assuming they won't
 be NULL. Else, our entire testing process is badly flawed if we can't
 notice an unallocated cache and nothing segfaulted? :)

 Because to that extent, we have a LOT of callsite that assume that what is
 initialized in init() functions are safe to use at runtime (just see
 `rendcache.c` and friends).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
-+
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:  #23300   | Points:
 Reviewer:  asn  |Sponsor:
-+

Comment (by asn):

 Patch looks good. One thing makes me anxious: We call
 `DIGEST256MAP_FOREACH_MODIFY` on so many digestmaps without first checking
 that they are not-NULL. I don't think the `foreach` functions check for
 NULL before iterating which might cause segfaults. Shouldn't we check that
 the maps are non-NULL?

 Other than that, LGTM.

 Feel free to fix the above or not and then mark it as `merge_ready`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
-+
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  enhancement  | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:  #23300   | Points:
 Reviewer:  asn  |Sponsor:
-+
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => asn


Comment:

 Branch `ticket23355_032_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM

[Tor Bug Tracker & Wiki]

#23355: prop224: Implement a client purge state for NEWNYM
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop224, tor-hs
Actual Points:|  Parent ID:  #23300
   Points:|   Reviewer:
  Sponsor:|
--+
 Similar to `rend_client_purge_state()`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs