Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 I'm always afraid whenever there's a chance that what we're testing has
 diverged from what we're running--so, thanks for double-checking that we
 actually have been testing this code.

 Squashed and merging to 0.3.2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+

Comment (by asn):

 OK I tested this branch again to make sure that nothing broke in the
 meanwhile.
 Branch seems to work well.

 To test, I used a client with this branch, connected to an hsv3 service
 and made sure that the rendezvous point used supported the hsv3 protocol
 and data made it to the service. I did this test about 20 times to make
 sure that we only pick legit RPs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Ouch. Seems like I left a bad comment in there.

 Pushed a fixup that addresses it.

 Let me know if you want me to rebase the whole branch on master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by nickm):

 * status:  reopened => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Okay; I merged the spec branch, but I get a pile of warnings when I try to
 merge it.  It looks like there was a runaway comment.

 I'm fine with just fixing the comment and merging, but if it's been
 unbuildable, that means that nobody has has tried testing the code, right?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  reopened
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by nickm):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by asn):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Spec patch can be found in `bug23361` in my repo. Putting this back in
 `needs_review`.

 I also made #23420 for the padding feature that David mentioned in
 comment:11.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+

Comment (by dgoulet):

 Replying to [comment:10 nickm]:
 > Also, this seems to violate proposal 224 section 4.3, which says that we
 _can_ use older rendezvous points.  Why  did we decide not to do that?

 That is a spec issue that needs to be updated. Back at the Montreal hidden
 service meeting, we realized that we needed legacy rendezvous point to
 relay an HS cell that had more bytes than the 20 bytes rendezvous cookie
 and that patch got in 0.2.9 (commit `be0e1e9e2f6`). So, HS client can
 *not* use RPs below that version which is `HSRend=2`.

 *HOWEVER*, we should most certainly pad all RENDEZVOUS cells in the legacy
 HS system so v2 and v3 cells look "alike".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Also, this seems to violate proposal 224 section 4.3, which says that we
 _can_ use older rendezvous points.  Why  did we decide not to do that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+

Comment (by nickm):

 Code looks okay.

 This still needs the spec change that teor mentioned above, right?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Doc fixes done, and force pushed branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 * `uncanibalizable` --> I think missing a `n`.

 * Not sure about this log info: `log_info(LD_GENERAL, "Getting v3 rp
 circuit!");`

 Rest lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Fixup branch pushed at `bug23361_032_01` in my repo!

 Contains two fixup commits: One fixes the hsv3 circuit detection, and the
 second regulates cannibalization for hsv3 rp circuits.

 Let me know if you have any questions. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+

Comment (by teor):

 This also needs a spec change. (Or maybe I missed the relevant part in the
 spec.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+

Comment (by arma):

 You might also find it useful to put a warn message in, if you're about to
 send a v3 rend request to a relay that doesn't support a v3 rend request.
 In case there are other edge cases (or new ones show up in the future).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Patch does not handle cannibalized circs correctly. Cannibalized circs to
 non-v3-supporting nodes should not be used for v3 rend.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
-+
 Reporter:  asn  |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:  SponsorR-can
-+
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => asn


Comment:

 See branch: `bug23361_032_01`

 The change it not that trivial but I hope simple enough.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23361 [Core Tor/Tor]: prop224: client can pick super old rendezvous points

[Tor Bug Tracker & Wiki]

#23361: prop224: client can pick super old rendezvous points
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop224, tor-hs
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:  SponsorR-can  |
--+
 We just discovered that we dont enforce protover rules when prop224
 clients pick rendezvous points, so we end up picking rps on 0.2.8 which
 make our circuits hang.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs