Re: [tor-bugs] #23425 [Applications/Tor Browser]: Build fails when running without a terminal

[Tor Bug Tracker & Wiki]

#23425: Build fails when running without a terminal
+
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201709R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good, merged to `master` (commit
 e21581e108a44915c0bd0f2acd346b02288a52a0).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23425 [Applications/Tor Browser]: Build fails when running without a terminal

[Tor Bug Tracker & Wiki]

#23425: Build fails when running without a terminal
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201709R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  assigned => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam201709 => tbb-rbm,
   TorBrowserTeam201709R


Comment:

 Branch `bug_23425_v2` has a patch to fix that:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_23425_v2

 I did a full rebuild using this patch to check that it didn't break the
 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23425 [Applications/Tor Browser]: Build fails when running without a terminal

[Tor Bug Tracker & Wiki]

#23425: Build fails when running without a terminal
-+-
 Reporter:  boklm|  Owner:  boklm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201709
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The Tor Browser build is failing with the following error when running
 without a terminal (such as in a cron job):
 {{{
 failed to set the terminal from the stdin: inappropriate ioctl for device
 }}}

 I think the reason is that in `projects/common/runc-config.json`, we have
 `process.terminal` set to `true`. We should set it to `false` when we are
 doing a build, but change it to `true` when we open a debugging shell.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs