Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803, tbb-backported  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201803R, GeorgKoppen201803, tbb-backport =>
 TorBrowserTeam201803R, GeorgKoppen201803, tbb-backported


Comment:

 Backported to `tor-browser-52.8.0esr-7.5-1` (commit
 c4d20a867e257b15895cc2123e2c88b80df70b41 and
 e52a50f2099501efd4e2892a702a1a3730439426). Should be available in 7.5.4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803, tbb-backport|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201803R, GeorgKoppen201803 =>
 TorBrowserTeam201803R, GeorgKoppen201803, tbb-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:21 mcs]:
 > Replying to [comment:18 arthuredelstein]:
 > > As a version of these patches have landed in Mozilla, shall we
 backport them to include in the next Tor Browser alpha?
 >
 > I thought of doing this a couple of weeks ago, but I got stuck because
 the automated test fails for a strange reason, at least in my non-rbm
 macOS build. What happens is that an
 SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED error occurs while trying to
 load
 
https://example.com/browser/browser/base/content/test/siteIdentity/test_no_mcb_for_onions.html
 >
 > Manually testing does show that the patch is correct. The main advantage
 over the patches from comment:15 is that pref caching is included. You can
 find the two commits here:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/log/?h=bug23439-01

 Hm. So, I think the test in your branch is at the wrong place. In ESR 52
 the MCB tests are under browser/base/content/test/general. They got later
 moved to /browser/base/content/test/siteIdentity. We should keep that
 place while we are on ESR 52 I think. I actually wonder how running that
 test got that far for you given that `assertMixedContentBlockingState()`
 is defined in browser/base/content/test/general/head.js. I remember that
 one being broken made me actually realize that the location of the tests
 moved between ESR52 and m-c. Anyway, I've fixed that in
 1316acb053d6191176e9ae4e4f502415b068525e.

 The code backport looks good although I think I am not so happy about
 essentially reverting e3f5021a4103f1cdc4e902c6ecded73bdcf5327b without
 actually indicating that. But in order to avoid another roundtrip I'll
 take it as-is. (commit 680dece41e71d30afd4616aa19001c60e55dc852). Both
 commits landed on `tor-browser-52.7.2esr-8.0-1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:18 arthuredelstein]:
 > As a version of these patches have landed in Mozilla, shall we backport
 them to include in the next Tor Browser alpha?

 I thought of doing this a couple of weeks ago, but I got stuck because the
 automated test fails for a strange reason, at least in my non-rbm macOS
 build. What happens is that an SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED
 error occurs while trying to load
 
https://example.com/browser/browser/base/content/test/siteIdentity/test_no_mcb_for_onions.html

 Manually testing does show that the patch is correct. The main advantage
 over the patches from comment:15 is that pref caching is included. You can
 find the two commits here:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/log/?h=bug23439-01

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 I looked over both patches in https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_23439_v2 and they look good to me. gk mentioned it
 might be good to add the pref caching as Christoph suggested in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1382359

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:18 arthuredelstein]:
 > As a version of these patches have landed in Mozilla, shall we backport
 them to include in the next Tor Browser alpha?

 All that is needed is to review the patch in this bug (and adapt it if
 needed).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201803R,   |  Actual Points:
  GeorgKoppen201803  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 As a version of these patches have landed in Mozilla, shall we backport
 them to include in the next Tor Browser alpha?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  GeorgKoppen201802,   |  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  GeorgKoppen201802, TorBrowserTeam201802 => GeorgKoppen201802,
 TorBrowserTeam201802R
 * cc: arthuredelstein (added)
 * status:  assigned => needs_review


Comment:

 `bug_23439_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_23439_v2) is up for review. It contains the code
 (f10bad83876aee09c716086db659ab2bbe9652af) and a test for it
 (a7d9d4cf255368eef139b1dbde7d16933bfcaa30). We might need to add other
 tests for the uplift, I'll ask the Mozilla folks about it. For us I think
 it's enough to have this one test for mixed content blocking exemption.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201712,|  Actual Points:
  GeorgKoppen201712  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 #24819 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23439 [Applications/Tor Browser]: Exempt .onion domains from mixed content warnings

[Tor Bug Tracker & Wiki]

#23439: Exempt .onion domains from mixed content warnings
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201709,|  Actual Points:
  GeorgKoppen201709  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * component:  - Select a component => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs