[tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal|   Keywords:  030-backport, 031-backport
Actual Points:  0.1   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 Instead, log a bug, and return the obvious answer: "there are no running
 bridges".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  030-backport, 031-backport, dos- |  Actual Points:  0.1
  resistance |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  030-backport, 031-backport => 030-backport, 031-backport, dos-
 resistance
 * status:  new => needs_review


Comment:

 Please see my branch bug23524.

 This bug can't be triggered in existing code, so there's no need to
 backport it unless we think we'll backport extra calls to this function.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  030-backport, 031-backport, dos- |  Actual Points:  0.1
  resistance |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I added an additional commit to make sure the bug warning isn't triggered
 by the code I added in #23347.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  030-backport, 031-backport, dos- |  Actual Points:  0.1
  resistance |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Nice; thank you!

 Merging now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  dos-resistance  |  Actual Points:  0.1
Parent ID:  #24367  | Points:  0.1
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:  030-backport, 031-backport, dos-resistance => dos-resistance
 * status:  closed => reopened
 * resolution:  fixed =>
 * parent:   => #24367


Comment:

 This was a bug on #23347, but now we're replacing uses of
 any_bridge_descriptors_known() iwith num_bridges_usable() > 0, we need to
 make this change there instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  dos-resistance  |  Actual Points:  0.1
Parent ID:  #24367  | Points:  0.1
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * status:  reopened => needs_review


Comment:

 This change is in my bug24367_032 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:  (none) => teor
 * status:  needs_review => assigned


Comment:

 setting owner

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Teor, did you mean "bug24367"?  I don't see "bug24367_032".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Oops, I might have forgotten to push it. They are the same.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Now I've pushed  bug24367_032, the relevant commit for this ticket is
 d7833c9d27.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready
 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.1.x-final


Comment:

 Yes, this seems okay; merging to 0.3.2.  Should part of this be a backport
 candidate?  If not, please close.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24367   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


Comment:

 I spoke too soon -- the unit tests break when I merge this branch:

 {{{
   FAIL src/test/test_entrynodes.c:618: assert(gs_br OP_EQ NULL):
 0x5585741f34b0 vs (nil)entrynodes/parse_from_state_full:
   [parse_from_state_full FAILED]
 entrynodes/get_guard_selection_by_name:
   FAIL src/test/test_entrynodes.c:802: assert(gs3 ==
 get_guard_selection_info())
   [get_guard_selection_by_name FAILED]

   FAIL src/test/test_entrynodes.c:2258: assert(r OP_EQ 0): -1 vs
 0entrynodes/drop_guards:
   [drop_guards FAILED]
 entrynodes/outdated_dirserver_exclusion:
   FAIL src/test/test_entrynodes.c:2777: expected log to contain "No
 primary or confirmed guards available."  Captured logs:
 1. info: "Not setting md restriction: only 0 usable guards.\n"
 2. info: "Trying to sample a reachable guard: We know of 0 in the
 USABLE_FILTERED set.\n"
 3. info: "  (That isn\'t enough. Trying to expand the sample.)\n"
 4. info: "Expanding the sample guard set. We have 0 guards in the
 sample, and 0 eligible guards to extend it with.\n"
 5. info: "Not expanding the guard sample any further; just ran out of
 eligible guards\n"
 6. info: "  (After filters [b], we have 0 guards to consider.)\n"
 7. info: "Trying to sample a reachable guard: We know of 0 in the
 USABLE_FILTERED set.\n"
 8. info: "  (That isn\'t enough. Trying to expand the sample.)\n"
 9. info: "Expanding the sample guard set. We have 0 guards in the
 sample, and 0 eligible guards to extend it with.\n"
10. info: "Not expanding the guard sample any further; just ran out of
 eligible guards\n"
11. info: "  (After filters [7], we have 0 guards to consider.)\n"
12. info: "Absolutely no sampled guards were available. Marking all
 guards for retry and starting from top again.\n"
13. info: "No router found for microdescriptor fetch; falling back to
 dirserver list.\n"
14. notice: "While fetching directory info, no running dirservers
 known. Will try again later. (purpose 19)\n"

   [outdated_dirserver_exclusion FAILED]
 4/1031 TESTS FAILED. (31 skipped)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24392   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:  #24367 => #24392


Comment:

 Yes, #24392 is assigned to you (nickm) to fix the unit tests, because I
 don't understand the guard code well enough.
 I split it off from #24367 because that ticket deals with a lot of
 different issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24392   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => merge_ready


Comment:

 Okay, I found the problem: the entrynode tests were depending on some
 global-state that some of the earlier tests were munging.  I haven't
 tracked down what global state exactly, though -- only enough to fix this.

 See my branch `bug24367_032`, based on yours.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24392   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Ok, I think we can do the reviews of this in #24367.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, review-group-26  |  Actual Points:  0.1
Parent ID:  #24392   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 On this commit, I'm mainly waiting to know whether Roger thinks that the
 merge should be blocked because of #24486

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23524 [Core Tor/Tor]: Avoid crashing when we ask for running bridges, but UseBridges is 0

[Tor Bug Tracker & Wiki]

#23524: Avoid crashing when we ask for running bridges, but UseBridges is 0
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  dos-resistance, 030-backport,|  Actual Points:  0.1
  031-backport   |
Parent ID:  #24392   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  dos-resistance, review-group-26, review-group-27 => dos-
 resistance, 030-backport, 031-backport
 * status:  merge_ready => needs_revision
 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.0.x-final


Comment:

 This was fixed in #24392 in master and 0.3.2.
 We might also need to backport this to 0.3.0 and 0.3.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs