Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:  SponsorV-can
---+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Sounds good to me; code looks good too.  Merging to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:  SponsorV-can
---+

Comment (by teor):

 It passes all the 'make test-network-all' integration tests, including the
 mixed test with tor-old at 0.3.1.9 (or 0.3.1.8).

 All the integration tests except mixed run with consensus method 28, which
 only puts IPv6 addresses in the microdesc consensus.
 Mixed runs at consensus method 26, which is the current public network
 method, with IPv6 addresses in microdescs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:  SponsorV-can
---+

Comment (by nickm):

 Please tell me a little about integration testing here.  How sure are we
 that this will work correctly once the authorities start updating to
 0.3.3?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:  SponsorV-can
---+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 ack.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:  SponsorV-can
---+

Comment (by teor):

 (I also updated both branches with some check-spaces and check-changes
 fixups. Oops!)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:  SponsorV-can
---+
Changes (by teor):

 * status:  needs_revision => needs_review
 * sponsor:   => SponsorV-can


Comment:

 Replying to [comment:10 dgoulet]:
 > * (Nitpick) For some more safety, I would `const` this variable:
 >
 > {{{
 > networkstatus_t *cons = networkstatus_get_reasonably_live_consensus(
 > }}}

 Fixed in
 {{{
 [bug23827_tree 35f350a8f7] fixup! fixup! Add
 networkstatus_consensus_has_ipv6() and unit tests
 }}}

 > Apart from that lgtm;
 >
 > Although a question, `node_awaiting_ipv6()` doesn't check for the
 descriptor (`node->ri`) anymore and the only trace for a reason of this I
 can find is in the commit message:
 >
 > {{{
 > If node_is_a_configured_bridge(), stop waiting for its IPv6 address
 in
 > a microdescriptor. The previous check for ri was inaccurate.
 > }}}

 There is also the changes file entry for that commit:

 {{{
 - Make IPv6-only clients wait for microdescs for relays, even if we
 were
   previously using descriptors (or were using them as a bridge) and
 have
   a cached descriptor for them.
 }}}

 > So was it specifically done before because of bridges and turned out to
 be inaccurate?

 It was specifically done because of bridges, but it would also stop
 waiting for mds if we had cached descriptors. It works in 0.3.2 and
 earlier, because we always check ri, rs, and md. But then we would
 sometimes chose the wrong address. (Remember that bridge bug?)

 It won't work after we merge #23975, because we check which directory
 documents we can use, then look for the address in them.

 > Or because now `node_has_ipv6_addr()` before takes care of looking at
 the descriptor if one?

 `node_has_ipv6_addr()` has similar issues with looking everywhere, and
 choosing the wrong address.

 After we merge #23975, `node_has_ipv6_addr()` will also check which
 directory documents we can use, then look for the address in them.

 I edited the comment to explain better in:
 {{{
 [bug23827_tree 270a604297] fixup! squash! Stop waiting for microdescs if
 the consensus supports IPv6 ORPorts
 }}}

 I also updated the commit message when I rebased and squashed.
 The rebase was complex, because we squashed my branch bug23826-23828
 before merging it.

 Please merge my branch bug23827-v2, which has the same code as
 bug23827_tree.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, review-group-27  |  Actual Points:  1
Parent ID:  #20916 | Points:  0.5
 Reviewer:  dgoulet|Sponsor:
---+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 * (Nitpick) For some more safety, I would `const` this variable:

 {{{
 networkstatus_t *cons = networkstatus_get_reasonably_live_consensus(
 }}}

 Apart from that lgtm;

 Although a question, `node_awaiting_ipv6()` doesn't check for the
 descriptor (`node->ri`) anymore and the only trace for a reason of this I
 can find is in the commit message:

 {{{
 If node_is_a_configured_bridge(), stop waiting for its IPv6 address in
 a microdescriptor. The previous check for ri was inaccurate.
 }}}

 So was it specifically done before because of bridges and turned out to be
 inaccurate? Or because now `node_has_ipv6_addr()` before takes care of
 looking at the descriptor if one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  1
Parent ID:  #20916| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  ipv6, regression => ipv6
 * status:  needs_revision => needs_review
 * actualpoints:   => 1


Comment:

 Please see my branch bug23827_tree, which uses the new consensus methods
 from bug23826-23828.

 We will probably need to do some squashing and rebasing before merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, regression  |  Actual Points:
Parent ID:  #20916| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Replying to [comment:2 teor]:
 > We should probably revise node_get_pref_ipv6_orport() so that it's a bit
 smarter, but let's do that in a different ticket.

 This is now #23975.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, regression  |  Actual Points:
Parent ID:  #20916| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by teor):

 The existing code from 0.2.8 will behave the right way once IPv6 addresses
 are moved into the microdesc consensus.

 It checks addresses in this order:
 * routerinfo / descriptor / rewrite bridge address
 * routerstatus / consensus
 * microdesc

 There are some minor changes needed to IPv6-only bootstrap (skipping the
 special case where the IPv6 microdescs come from fallbacks).

 We should probably revise node_get_pref_ipv6_orport() so that it's a bit
 smarter, but let's do that in a different ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ipv6, regression  |  Actual Points:
Parent ID:  #20916| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * points:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23827 [Core Tor/Tor]: Clients/Relays: Use IPv6 Addresses from microdesc consensus

[Tor Bug Tracker & Wiki]

#23827: Clients/Relays: Use IPv6 Addresses from microdesc consensus
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  ipv6, regression
Actual Points:|  Parent ID:  #20916
   Points:|   Reviewer:
  Sponsor:|
--+
 Client/Relay Implementation for #20916.

 We need to use the IPv6 addresses from consensuses with versions that
 implement #23826, and ignore microdesc IPv6 addresses.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs