Re: [tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Released and working (cf. [https://lists.torproject.org/pipermail/tor-
 dev/2017-October/012526.html announcement]).
 Closing.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Replying to [comment:4 karsten]:
 > Thanks for reviewing and testing!
 >
 > Regarding your commit b7bd616, I'm afraid that it's flawed: we cannot
 create a `FileWriter` for `this.historyFile` and create its parent
 directory ''afterwards'' by calling
 `this.historyFile.getParentFile().mkdirs()`. I'd say let's keep this
 change out of the patch release and focus on the bugs that we're aware of.
 We can still make things more robust when we have more time.

 Oh, I wanted to save typing, grr.  Good that you noticed, but I'd really
 like to have the enclosing try-catch(Exception) for the entire contents of
 that method.   That shouldn't hurt to be there.

 >
 > Your commit 3a72ead is a good catch! I tweaked it a bit by renaming
 `lastRestartedMillis()` to `calculateLastRestartedMillis()`. Save the
 verbs!

 ok.

 >
 > I pushed two branches to my public repository:
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-24012
 task-24012] contains your second commit rebased onto my earlier branch
 plus two squash commits, and
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=next next]
 contains the same changes squashed into one commit plus preparations for
 the patch release.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Thanks for reviewing and testing!

 Regarding your commit b7bd616, I'm afraid that it's flawed: we cannot
 create a `FileWriter` for `this.historyFile` and create its parent
 directory ''afterwards'' by calling
 `this.historyFile.getParentFile().mkdirs()`. I'd say let's keep this
 change out of the patch release and focus on the bugs that we're aware of.
 We can still make things more robust when we have more time.

 Your commit 3a72ead is a good catch! I tweaked it a bit by renaming
 `lastRestartedMillis()` to `calculateLastRestartedMillis()`. Save the
 verbs!

 I pushed two branches to my public repository:
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-24012
 task-24012] contains your second commit rebased onto my earlier branch
 plus two squash commits, and
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=next next]
 contains the same changes squashed into one commit plus preparations for
 the patch release.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 I tested a single run against the current collector recent directory,
 which should contain all problematic descriptors encountered during the
 last few days.

 All ant tests and checks pass.

 Unless anything else surfaces, this seems ready for merge and hotfix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Please review
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git?h=task-24012 my
 branch task-24012].  It contains another commit for making Onionoo more
 stable when history computation fails and another commit for preventing
 NPEs when bridges don't have an uptime value.

 (There are still tests missing here.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Here's the server descriptor:

 {{{
 @type server-descriptor 1.0
 router pearl000 35.203.138.1 9001 0 0
 signing-key
 -BEGIN RSA PUBLIC KEY-
 MIGJAoGBAKzTaN4tZGv1kiQWBzeuOk+ovr2LtIURlaVC38j6j/fQuYfuAZX/XvV1
 fQr9EVh+T617dh+frt2D0QDuzLUvP3hpgVozW94w+Ib85pUCne03f4rj3QYu5Qtg
 GvzShslZI6vgyy0g2jAOGa4jxT/UYAcKE5dQo8CBKA6Qb0P5Joc1AgMBAAE=
 -END RSA PUBLIC KEY-
 fingerprint 6832 5B4B 1E17 7374 B84D 372F 0304 6351 BEE7 FF6A
 onion-key
 -BEGIN RSA PUBLIC KEY-
 MIGJAoGBANN/gLTe05kWKPSEyYJeknuxQst+cVsVmZrZgIYNXuhPn+3XnWhEc10r
 ICa82FkB7hBH6REuW0ugGDc2QLwENmDiaBiFW1LDujEFeVlV8o0VSDwrL3VCPsPL
 zC4/zHqR4DmLFXp5V238MKj85Pud04g65piZCIAsy6hiGMDCoGdtAgMBAAE=
 -END RSA PUBLIC KEY-
 ntor-onion-key ATSN2Q9KwCeRu35agh/ChjX8MsgM/FGFRDUX6o9Sbmk
 platform Pearl 0fd5756 on Linux
 contact pe...@m15n.org https://github.com/mmcloughlin/pearl
 bandwidth 153600 307200 153600
 published 2017-10-25 18:00:28
 reject *:*
 proto Link=4 LinkAuth=1 Relay=2
 router-signature
 -BEGIN SIGNATURE-
 OyY0vQc5n2RYdkrXqfn09HoACJBx7GrBHZMnmNtlX5nJIL9N4eyyPvmxhmuC+A94
 dDE0u/6w3nCABikFFLHcKaBAdmYBdxrzk3imfVjzYZazHWWr/se8HxK1jibP186A
 8K8bdtMih127CGv3mn+g17uXFTbbuylM7r1xf8NpqRs=
 -END SIGNATURE-
 }}}

 Here's the consensus entry:

 {{{
 r pearl000 aDJbSx4Xc3S4TTcvAwRjUb7n/2o 97QY9wS38Dw33qiyzDiGOi4Mu/E
 2017-10-25 04:09:33 35.203.138.1 9001 0
 s Running Valid
 pr Link=4 LinkAuth=1 Relay=2
 w Bandwidth=20 Unmeasured=1
 p reject 1-65535
 }}}

 And
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-24012
 my task-24012 branch] contains what I came up with so far. Please review,
 test, improve!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24012 [Metrics/Onionoo]: Fix NullPointerExceptions from accessing descriptor parts that may be null

[Tor Bug Tracker & Wiki]

#24012: Fix NullPointerExceptions from accessing descriptor parts that may be 
null
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 There's a relay running an alternate Tor version that produces descriptors
 without "uptime" line, and the directory authorities don't include a "v"
 line for that relay, likely because its platform string does not include
 the magic word "Tor". Maybe there are similar issues.

 I'm working on a hotfix that I'll post here shortly and that needs review
 and more testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs