Re: [tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
-+-
 Reporter:  nickm|  Owner:
 |  chelseakomlo
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  rust, 033-triage-20180320,   |  bug
  033-removed-20180320   |  Actual Points:
Parent ID:  #24265   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 If C doesn't reject bad UTF-8, and Rust does, then that's a potential
 difference in behaviour.

 We could avoid this issue by making both C and Rust check that all
 directory documents are ASCII (#18938), or that they are all UTF-8. We
 have a proposal for making directory documents UTF-8.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
-+-
 Reporter:  nickm|  Owner:
 |  chelseakomlo
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  rust, 033-triage-20180320,   |  bug
  033-removed-20180320   |  Actual Points:
Parent ID:  #24265   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 No, I think we can close this ticket if that's how it works.  Thanks for
 the analysis!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
-+-
 Reporter:  nickm|  Owner:
 |  chelseakomlo
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, 033-triage-20180320,   |  Actual Points:
  033-removed-20180320   |
Parent ID:  #24265   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Hmmm, none of the functions are taking `&[u8]`s, so invalid UTF-8 string
 will be rejected when the C pointers are read from and converted into
 `String`s.  Unless I misunderstood and you wanted something else, we can
 probably close this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
--+
 Reporter:  nickm |  Owner:  chelseakomlo
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:  #24265| Points:
 Reviewer:|Sponsor:
--+
Changes (by isis):

 * cc: isis (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
--+
 Reporter:  nickm |  Owner:  chelseakomlo
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:  #24265| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * parent:   => #24265


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
--+
 Reporter:  nickm |  Owner:  chelseakomlo
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by chelseakomlo):

 * owner:  (none) => chelseakomlo
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24029 [Core Tor/Tor]: Test all rust functions' behavior when called from C with bad UTF8

[Tor Bug Tracker & Wiki]

#24029: Test all rust functions' behavior when called from C with bad UTF8
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 We should make sure that the various rust implementations of our protover
 functions will correctly detect and reject strings that aren't UTF-8

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs