Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 029-backport-maybe, security-low,   |
  guard-discovery-stats, chutney-wants, bwauth-  |
  wants, 034-triage-20180328,|
  034-removed-20180328, tor-bwauth, 031  |
  -unreached-backport-maybe, 035-triaged-|
  in-20180711, 032-unreached-backport-maybe  |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.3.4.x-final => Tor: 0.2.9.x-final


Comment:

 merged to 0.2.9 and forward. There were some small conflicts, but they
 appeared to be pretty straightforward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 031-backport-   |
  maybe, 029-backport-maybe, security-low,   |
  guard-discovery-stats, chutney-wants, bwauth-  |
  wants, 034-triage-20180328,|
  034-removed-20180328, tor-bwauth   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:24 juga]:
 > I don't know what is missing that makes
 `router/check_descriptor_bandwidth_changed` not found.

 `router_tests` was missing in `test.h`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 031-backport-   |
  maybe, 029-backport-maybe, security-low,   |
  guard-discovery-stats, chutney-wants, bwauth-  |
  wants, 034-triage-20180328,|
  034-removed-20180328, tor-bwauth   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:30 nickm]:
 > One issue I spotted: the router tests won't actually run, since they
 aren't in the big list at the end of tests.c.

 What do you mean by this?, maybe it has to do with my previous comment?.
 After that change, `test-suite.log` contains:
 `router/check_descriptor_bandwidth_changed: [forking] OK`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 031-backport-   |
  maybe, 029-backport-maybe, security-low,   |
  guard-discovery-stats, chutney-wants, bwauth-  |
  wants, 034-triage-20180328,|
  034-removed-20180328, tor-bwauth   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Thanks arma, i've made the changes you suggested. See the new commits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by arma):

 Replying to [comment:31 arma]:
 > All the more reason to open the "explicitly mark descriptor dirty when
 beginning/ending hibernation, rather than implicitly doing it as part of
 the bandwidth check" ticket.

 I opened #26713 for this idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:  fixed
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  needs_review => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * version:  Tor: unspecified =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 arma, you okay with this now?  I'm planning to merge it soon unless
 somebody objects

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by arma):

 i haven't looked, and have lost track of how to look. i say if ahf likes
 it, go for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 I've squashed this into a branch called `bug24104_029_squashed`, and
 merged that branch to master.  Marking for possible backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by cypherpunks3):

 Replying to [comment:46 nickm]:
 > I've squashed this into a branch called `bug24104_029_squashed`, and
 merged that branch to master.

 Nothing's been pushed to the master branch in the repo yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 whoops, you're right. Looks like I didn't finish resolving conflicts
 there.  Trying again...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 029-backport-   |
  maybe, security-low, guard-discovery-stats,|
  chutney-wants, bwauth-wants,   |
  034-triage-20180328, 034-removed-20180328, |
  tor-bwauth, 031-unreached-backport-maybe, 035  |
  -triaged-in-20180711   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 There; merged. Marking for possible backport, again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24104 [Core Tor/Tor]: Delay descriptor bandwidth reporting on established relays (was: Delay descriptor bandwidth reporting on large relays)

[Tor Bug Tracker & Wiki]

#24104: Delay descriptor bandwidth reporting on established relays
-+-
 Reporter:  teor |  Owner:  juga
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  034-backport-maybe, 033-backport-|  Actual Points:
  maybe, 032-backport-maybe, 031-backport-   |
  maybe, 029-backport-maybe, security-low,   |
  guard-discovery-stats, chutney-wants, bwauth-  |
  wants, 034-triage-20180328,|
  034-removed-20180328, tor-bwauth   |
Parent ID:  #25925   | Points:  1
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by arma):

 (changing ticket title to reflect the new plan)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs