Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+
Changes (by asn):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


Comment:

 Pushing this to 034, I think we have more important prop224 stuff to fix.
 Please put it back in 033 if you disagree!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+
Changes (by dgoulet):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


Comment:

 Ok btw, we have this in `hs_config.c`:

 {{{
   /* XXX: Validate if we have any service that has the given service dir
 path.
* This has two problems:
*
* a) It's O(n^2), but the same comment from the bottom of
*rend_config_services() should apply.
*
* b) We only compare directory paths as strings, so we can't
*detect two distinct paths that specify the same directory
*(which can arise from symlinks, case-insensitivity, bind
*mounts, etc.).
*
* It also can't detect that two separate Tor instances are trying
* to use the same HiddenServiceDir; for that, we would need a
* lock file.  But this is enough to detect a simple mistake that
* at least one person has actually made. */
 }}}

 So known issue but not that simple to fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  reopened => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+

Comment (by nickm):

 I think it's less input sanitization, and more making sure that the
 directories aren't actually the same directory. (Consider the symlink
 case.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+

Comment (by dgoulet):

 Oh we aren't sanitizing the input indeed. Do we have anything in tor to do
 that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 You can just specify the same directory in two different ways, I think:

 {{{
 HiddenServiceDir /path/abc
 HiddenServicePort 80
 HiddenServiceDir /path/abc/.
 HiddenServicePort 80
 }}

 Also, symlinks would let you do that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  not a bug
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+
Changes (by dgoulet):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 This is already handled. You can't have two hidden services in the same
 directory path. The configuration process makes sure of that and error
 with:

 {{{
 Nov 14 07:51:16.145 [warn] Another hidden service is already configured
 for directory "DIR"
 }}}

 And tor stops. If you were able to make Tor load up with the same HS
 directory, please tell us how. Closing this for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
+
 Reporter:  cypherpunks |  Owner:  (none)
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  | Points:  0.3
 Reviewer:  |Sponsor:
+
Changes (by asn):

 * keywords:   => tor-hs prop224
 * points:   => 0.3
 * milestone:   => Tor: 0.3.2.x-final


Comment:

 Hm, not sure what's the right behavior here, but given how frequent this
 behavior must be when upgrading from v2 -> v3 we should think about it.
 Marking this as 0.3.2 for now, but we can defer it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24269 [Core Tor/Tor]: Raise a FATAL error if the user tried to combine v2 and prop224 hidden service in same directory (was: Raise a FATAL error if the user tried to combine v3 and v3

[Tor Bug Tracker & Wiki]

#24269: Raise a FATAL error if the user tried to combine v2 and prop224 hidden
service in same directory
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs