[tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal|   Keywords:  prop224
Actual Points:|  Parent ID:
   Points:  2 |   Reviewer:
  Sponsor:|
--+
 My prop224 service stopped working. I did some digging and I noticed that
 it's only uploading one of its two descriptors, so it's only uploading
 `next` or `current` but not both. This has reachability consequences.

 Here are some logs (grepping for `run_upload_descriptor_event()`):
 {{{
 Nov 16 15:06:51.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 15:51:04.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 16 17:00:25.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 16 17:06:02.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 18:22:23.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 16 19:05:22.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 19:05:22.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 16 20:13:08.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 20:20:11.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 16 21:18:50.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 16 21:30:21.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 22:49:34.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 17 00:23:30.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 17 01:08:16.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 5/3
 introduction points.
 Nov 17 01:50:14.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 03:37:20.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 04:40:29.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 05:30:14.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 06:41:39.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 08:11:41.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 09:18:45.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 10:40:24.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 12:22:55.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 13:30:14.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 14:39:14.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 3/3
 introduction points.
 Nov 17 14:40:15.000 [info] run_upload

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.4-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  prop224, tor-hs, |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 With OPE code as the revision counter and the fixes in #23603, I think we
 are done here. We've seen other upload issues but there are specific
 tickets for it now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal| Resolution:
 Keywords:  prop224   |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+

Comment (by asn):

 Uploading info logs for this issue. Still haven't add debug logs on
 `should_service_upload_descriptor()` yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
--+
 Reporter:  asn   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal| Resolution:
 Keywords:  prop224   |  Actual Points:
Parent ID:| Points:  2
 Reviewer:|Sponsor:
--+
Changes (by asn):

 * Attachment "bug24346.log.gz" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+
Changes (by dgoulet):

 * status:  new => accepted
 * owner:  (none) => dgoulet
 * cc: dgoulet (removed)
 * keywords:  prop224 => prop224, tor-hs


Comment:

 Agree, I've looked at the logs and notice here, the next descriptor stops
 being uploaded:

 {{{
 Nov 16 21:30:21.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 16 22:49:34.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 17 00:23:30.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service current descriptor for service onion with 3/3
 introduction points.
 Nov 17 01:08:16.000 [info] run_upload_descriptor_event(): Initiating
 upload for hidden service next descriptor for service onion with 5/3
 introduction points.
 }}}

 And then before 01:08:16, the current is discarded, the next is the new
 current (`current = next`) and we create a new next descriptor. So at that
 point, the current descriptor becomes the one never uploading and the next
 is fine because it is a brand new one. Interestingly enough, this pattern
 comes back hours later...

 I can't tell from the logs why this is happening so as suggested, we need
 to log every failing condition in `should_service_upload_descriptor()` so
 we can have more information on why it is deciding to not upload the
 descriptor...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 See branch for the added logging statements: `ticket24346_032_01`

 Once merged, lets move this ticket to 033 in `needs_information` because
 without these log statements, I fear understanding whats going on will be
 near impossible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 dgoulet]:
 > See branch for the added logging statements: `ticket24346_032_01`
 >
 > Once merged, lets move this ticket to 033 in `needs_information` because
 without these log statements, I fear understanding whats going on will be
 near impossible.

 Hm. Here is how this branch looks like on my HS (I bumped the msgs to
 warn):
 {{{
 Nov 30 08:25:03.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512030303. [1198
 similar message(s) suppressed in last 600 seconds]
 Nov 30 08:35:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512030902. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 08:45:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512031502. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 08:55:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512032102. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 09:05:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512032702. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 09:15:03.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512033303. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 09:25:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512033902. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 09:35:03.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512034503. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 09:45:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512035656, it is now 1512035102. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 09:55:03.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512035703. [1198
 similar message(s) suppressed in last 600 seconds]
 Nov 30 10:05:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512036302. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 10:15:02.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512036902. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 10:20:59.000 [warn] Service onion can't upload its current
 descriptor. Intro circuits aren't yet all established (2/3). [712 similar
 message(s) suppressed in last 60 seconds]
 Nov 30 10:30:58.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512037858. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 10:40:59.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512038459. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 10:50:58.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512039058. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 11:00:58.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512039658. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 11:10:58.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512040258. [1197
 similar message(s) suppressed in last 600 seconds]
 Nov 30 11:20:58.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512040858. [1199
 similar message(s) suppressed in last 600 seconds]
 Nov 30 11:30:59.000 [warn] Service onion can't upload its current
 descriptor. Next upload time is 1512042695, it is now 1512041459. [1199
 similar message(s) suppressed in last 600 seconds]
 }}}

 As you can see it only cares about current desc. I think that's because
 the ra

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+

Comment (by dgoulet):

 Arf indeed... So I think we either want to have a `rlimit_t` object per
 condition so each of them control their limit.

 Second thing, we probably want to decouple `current` and `next` then so
 they don't get caught in the same rlimit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+

Comment (by dgoulet):

 Two things:

 1) See https://trac.torproject.org/projects/tor/ticket/23603#comment:19
 for the likely cause of this.

 2) We maybe want to hold off on this patch because this is getting weirdly
 complicated and we kind of found the issue. I agree for "later" it would
 be good to have but 032 is near stable so we can possibly postpone?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+
Changes (by asn):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_revision => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24346 [Core Tor/Tor]: prop224: Service stops uploading one of its two descriptors

[Tor Bug Tracker & Wiki]

#24346: prop224: Service stops uploading one of its two descriptors
-+
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
-+
Changes (by asn):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


Comment:

 There is a theory that this was caused by the now-fixed #23603. I'll push
 this to 034,  and let's see if it will come back again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs